[Renderer] Move InputPreprocessor into Renderer (2/2)#34560
[Renderer] Move InputPreprocessor into Renderer (2/2)#34560vllm-bot merged 29 commits intovllm-project:mainfrom
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
There was a problem hiding this comment.
Code Review
This pull request continues the significant refactoring of moving the input preprocessing logic from the engine into the renderer layer. The changes are extensive and affect many files, but they appear consistent and well-aligned with the goal of centralizing input processing. This refactoring improves the separation of concerns and should make the engine core cleaner.
I've identified one potential high-severity issue in vllm/beam_search.py where the logic to differentiate between token-only and multimodal prompts could be brittle. I've provided a suggestion to make it more robust by checking the prompt's type field directly.
Overall, this is a good step forward in improving the architecture of the input processing pipeline.
b0213cf to
f26d529
Compare
|
/gemini review |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
There was a problem hiding this comment.
Code Review
This pull request continues the significant refactoring of moving input preprocessing logic from the InputPreprocessor into the Renderer. The changes are extensive, touching many files across the entrypoints and engine components to adapt to the new ProcessorInputs data structure and the updated rendering flow. The InputPreprocessor is now a thin wrapper for backward compatibility, and the core logic for tokenization, multimodal processing, and preparing engine inputs resides within the BaseRenderer. This is a positive change for code organization and clarity.
I've found one critical issue in the handling of text-only encoder-decoder models which I've commented on. Other than that, the refactoring appears solid and consistent with the stated goals.
|
Hi @DarkLight1337, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
Hi @DarkLight1337, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
Hi @DarkLight1337, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Purpose
Towards #22880
ProcessorInputsto the LLM engine instead of raw prompts, using Renderer to process the raw prompts intoProcessorInputswhere applicable.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.