[CI/Build] Remove use of skip_v1#34699
Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom Feb 18, 2026
Merged
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the skip_v1 pytest marker and its usage across the codebase. The changes are consistent and correctly remove the marker from CI configurations, the pytest configuration in pyproject.toml, and a test case. The changes are straightforward, correct, and align with the stated purpose of the PR. I have no issues to report.
skip_v1skip_v1
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
khluu
approved these changes
Feb 18, 2026
jiangkuaixue123
pushed a commit
to jiangkuaixue123/vllm
that referenced
this pull request
Apr 28, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
CI can pass regardless of
skip_v1flag (except for https://buildkite.com/vllm/ci/builds/51898/steps/canvas?sid=019c6b08-b21c-4c5e-9194-91966b03d9b4&tab=output uncovered by #34560, which will be handled in a separate PR) so let's remove them from all tests.Also fixed detokenizer tests not actually being run in CI.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.