Skip to content

[CI/Build] Remove use of skip_v1#34699

Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom
DarkLight1337:drop-skip-v1
Feb 18, 2026
Merged

[CI/Build] Remove use of skip_v1#34699
DarkLight1337 merged 2 commits intovllm-project:mainfrom
DarkLight1337:drop-skip-v1

Conversation

@DarkLight1337
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 commented Feb 17, 2026

Purpose

CI can pass regardless of skip_v1 flag (except for https://buildkite.com/vllm/ci/builds/51898/steps/canvas?sid=019c6b08-b21c-4c5e-9194-91966b03d9b4&tab=output uncovered by #34560, which will be handled in a separate PR) so let's remove them from all tests.

Also fixed detokenizer tests not actually being run in CI.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 17, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the skip_v1 pytest marker and its usage across the codebase. The changes are consistent and correctly remove the marker from CI configurations, the pytest configuration in pyproject.toml, and a test case. The changes are straightforward, correct, and align with the stated purpose of the PR. I have no issues to report.

@mergify mergify Bot added the ci/build label Feb 17, 2026
@DarkLight1337 DarkLight1337 changed the title [CI/Build[ Remove use of skip_v1 [CI/Build] Remove use of skip_v1 Feb 17, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 merged commit 30ebe0d into vllm-project:main Feb 18, 2026
16 checks passed
@DarkLight1337 DarkLight1337 deleted the drop-skip-v1 branch February 18, 2026 04:19
jiangkuaixue123 pushed a commit to jiangkuaixue123/vllm that referenced this pull request Apr 28, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants