[Renderer] Deprecate code paths for old input processing#34775
Merged
vllm-bot merged 2 commits intovllm-project:mainfrom Feb 18, 2026
Merged
[Renderer] Deprecate code paths for old input processing#34775vllm-bot merged 2 commits intovllm-project:mainfrom
vllm-bot merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Contributor
There was a problem hiding this comment.
Code Review
This pull request deprecates old input processing code paths, encouraging the use of the Renderer for preprocessing. The changes are consistent and well-aligned with this goal, removing tokenization_kwargs from several internal functions and adding clear deprecation warnings for old APIs. However, I've identified a high-severity issue in the backward compatibility implementation for Platform.validate_request which could break custom platform implementations. My review includes suggestions to fix this while preserving the intended deprecation path.
Contributor
|
Documentation preview: https://vllm--34775.org.readthedocs.build/en/34775/ |
Isotr0py
approved these changes
Feb 18, 2026
Copilot AI
pushed a commit
to machov/vllm
that referenced
this pull request
Mar 10, 2026
…t#34775) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up to #34560
Encourage people to use Renderer code path instead of applying preprocessing inside InputProcessor.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.