Skip to content

[Renderer] Deprecate code paths for old input processing#34775

Merged
vllm-bot merged 2 commits intovllm-project:mainfrom
DarkLight1337:apply-renderer-deprecations
Feb 18, 2026
Merged

[Renderer] Deprecate code paths for old input processing#34775
vllm-bot merged 2 commits intovllm-project:mainfrom
DarkLight1337:apply-renderer-deprecations

Conversation

@DarkLight1337
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 commented Feb 18, 2026

Purpose

Follow-up to #34560

Encourage people to use Renderer code path instead of applying preprocessing inside InputProcessor.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 18, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates old input processing code paths, encouraging the use of the Renderer for preprocessing. The changes are consistent and well-aligned with this goal, removing tokenization_kwargs from several internal functions and adding clear deprecation warnings for old APIs. However, I've identified a high-severity issue in the backward compatibility implementation for Platform.validate_request which could break custom platform implementations. My review includes suggestions to fix this while preserving the intended deprecation path.

Comment thread vllm/v1/engine/input_processor.py
Comment thread vllm/v1/engine/input_processor.py
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 18, 2026

Documentation preview: https://vllm--34775.org.readthedocs.build/en/34775/

@mergify mergify Bot added the documentation Improvements or additions to documentation label Feb 18, 2026
@vllm-bot vllm-bot merged commit a766b30 into vllm-project:main Feb 18, 2026
45 of 51 checks passed
@DarkLight1337 DarkLight1337 deleted the apply-renderer-deprecations branch February 18, 2026 08:38
Copilot AI pushed a commit to machov/vllm that referenced this pull request Mar 10, 2026
…t#34775)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation frontend ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants