Skip to content

[Bugfix] Fix lora tests#34834

Merged
vllm-bot merged 5 commits intovllm-project:mainfrom
DarkLight1337:fix-lora-tests
Feb 18, 2026
Merged

[Bugfix] Fix lora tests#34834
vllm-bot merged 5 commits intovllm-project:mainfrom
DarkLight1337:fix-lora-tests

Conversation

@DarkLight1337
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 commented Feb 18, 2026 •
edited by github-actions Bot
Loading

Purpose

Regession was introduced by #34560 as _resolve_lora_reqs wasn't actually being called.

FIX #34802
FIX #34804

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@DarkLight1337
[Bugfix] Fix lora tests
1ce7a38 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 18, 2026
@mergify mergify Bot added frontend qwen Related to Qwen models labels Feb 18, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 18, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @DarkLight1337.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added needs-rebase bug Something isn't working labels Feb 18, 2026
@DarkLight1337
Doc
e8b906a 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Merge branch 'main' into fix-lora-tests
1860835 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) February 18, 2026 17:23
@mergify mergify Bot removed the needs-rebase label Feb 18, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Feb 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses regressions in LoRA tests for multimodal models, specifically focusing on Qwen2-VL and Qwen2.5-VL. The changes refactor the multimodal LoRA resolution logic in the LLM entrypoint to be more robust and correctly handle individual requests within a batch. Additionally, the tests are updated to accommodate the full text output of beam search and fix assertion message formatting. I have identified one high-severity bug in a test assertion message that should be corrected to ensure clear failure reporting.

Comment thread tests/lora/test_qwenvl.py
mgoin
mgoin approved these changes Feb 18, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just an assert message bug

Comment thread tests/lora/test_qwenvl.py Outdated
@mgoin
Update tests/lora/test_qwenvl.py
ca47a3d 
Signed-off-by: Michael Goin <mgoin64@gmail.com>
@mgoin
Copy link
Copy Markdown
Member

mgoin commented Feb 18, 2026 •
edited
Loading

Looks like LoRA 4 is still an issue

[2026-02-18T18:51:20Z] =================================== FAILURES ===================================
[2026-02-18T18:51:20Z] _______________ test_default_mm_lora_does_not_expand_string_reqs _______________
[2026-02-18T18:51:20Z]
[2026-02-18T18:51:20Z] >   assert engine_kwargs["prompt_text"] == AUDIO_PROMPT
[2026-02-18T18:51:20Z] E   KeyError: 'prompt_text'
[2026-02-18T18:51:20Z]
[2026-02-18T18:51:20Z] lora/test_default_mm_loras.py:157: KeyError

@DarkLight1337
Copy link
Copy Markdown
Member Author

DarkLight1337 commented Feb 18, 2026

Fixing

@DarkLight1337
Fix
0e8f37a 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
alex-jw-brooks
alex-jw-brooks approved these changes Feb 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@alex-jw-brooks alex-jw-brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these!

@mgoin
Copy link
Copy Markdown
Member

mgoin commented Feb 18, 2026

Resolved lora tests, other failures are unrelated

@vllm-bot vllm-bot merged commit 61cf087 into vllm-project:main Feb 18, 2026
47 of 53 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-lora-tests branch February 19, 2026 01:55
jmamou pushed a commit to jmamou/vllm that referenced this pull request Feb 23, 2026
@DarkLight1337 @mgoin @jmamou
[Bugfix] Fix lora tests (vllm-project#34834)
3547d26 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Michael Goin <mgoin64@gmail.com>
Co-authored-by: Michael Goin <mgoin64@gmail.com>
Copilot AI pushed a commit to machov/vllm that referenced this pull request Mar 10, 2026
@DarkLight1337 @mgoin
[Bugfix] Fix lora tests (vllm-project#34834)
ed46164 
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Michael Goin <mgoin64@gmail.com>
Co-authored-by: Michael Goin <mgoin64@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgoin mgoin mgoin approved these changes

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat approved these changes

@jeejeelee jeejeelee Awaiting requested review from jeejeelee jeejeelee is a code owner

+3 more reviewers

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

@alex-jw-brooks alex-jw-brooks alex-jw-brooks approved these changes

@bnellnm bnellnm bnellnm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working frontend qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI Failure]: Lora failed tests lora/test_default_mm_loras.py [CI Failure]: Lora failed tests qwen2vl beam search

6 participants

@DarkLight1337 @mgoin @alex-jw-brooks @bnellnm @robertgshaw2-redhat @vllm-bot