[CI] Optimize entrypoints API server tests#23896
[CI] Optimize entrypoints API server tests#23896csahithi wants to merge 22 commits intovllm-project:mainfrom
Conversation
|
wow! great job! |
tests/entrypoints/openai/embedding_tests/test_encoder_decoder.py
Outdated
Show resolved
Hide resolved
tests/entrypoints/openai/embedding_tests/test_optional_middleware.py
Outdated
Show resolved
Hide resolved
68a2e19 to
1b41751
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Thanks @csahithi this is great!!
Replaced large models with smaller ones -
hmellor/tiny-random-LlamaForCausalLM,microsoft/DialoGPT-small
Is the reason for the latter that the former doesn't have a chat template?
If so we can just ask @hmellor to add the llama 3.2 chat template and replace them all with that.
Oh sorry I see that it does already have a chat template. Then I'm curious what's the reason for using microsoft/DialoGPT-small too?
I know you have ideas for possible further streamlining but in the interests of incremental improvement could we get this merged first?
Could you fix the merge conflicts and we can see what the new CI timings are like after that too.
|
If anything needs changing about |
4732592 to
e799966
Compare
aac1623 to
fba4775
Compare
|
CI failures look related |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Sahithi Chigurupati <chigurupati.sahithi@gmail.com>
137c6e3 to
525293f
Compare
It looks like this is because that test used to run the server with Not sure if there are others which had test-specific args that we should look out for? |
|
Interestingly it seems that We can separately follow up on that but for now it would be good to have this test at least work as it did before, i.e. exercise the -1 case even though it's not properly checking the top_logprob count of the output. We can still change it to use I've opened #26194 for this issue. |
Signed-off-by: Sahithi Chigurupati <chigurupati.sahithi@gmail.com>
Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Nick Hill <nhill@redhat.com>
…nt-tests-optimize
|
This pull request has merge conflicts that must be resolved before it can be |
Yes,
I've submitted a PR to fix this issue, sorry, the original PR didn't check the length of |
|
These conflicts are caused by our migration to |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
I've got the merge past |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Thanks @hmellor! |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
This pull request has merge conflicts that must be resolved before it can be |
|
Any update on this? |
|
Closing as it's now too stale. #31228 does a small amount of organising but not on the same scale as this PR did. |
Purpose
hmellor/tiny-random-LlamaForCausalLM,microsoft/DialoGPT-smallTest Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.