[Bugfix] fixed top_logprobs: -1 does not appear to work as intended#26470
Merged
chaunceyjiang merged 4 commits intovllm-project:mainfrom Oct 10, 2025
Merged
[Bugfix] fixed top_logprobs: -1 does not appear to work as intended#26470chaunceyjiang merged 4 commits intovllm-project:mainfrom
chaunceyjiang merged 4 commits intovllm-project:mainfrom
Conversation
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
chaunceyjiang
requested review from
DarkLight1337,
NickLucche,
aarnphm,
robertgshaw2-redhat and
simon-mo
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where top_logprobs: -1 did not function as intended to return all logprobs. The fix in vllm/entrypoints/openai/serving_chat.py correctly adjusts the conditional logic to handle this special case. The accompanying test modifications in tests/entrypoints/openai/test_chat_echo.py are appropriate and validate the correction. The changes are sound and effectively resolve the issue. I have not identified any issues of high or critical severity.
5 tasks
DarkLight1337
added
the
ready
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Dhruvilbhatt
pushed a commit
to Dhruvilbhatt/vllm
that referenced
this pull request
Oct 14, 2025
…llm-project#26470) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: Dhruvil Bhatt <bhattdbh@amazon.com>
bbartels
pushed a commit
to bbartels/vllm
that referenced
this pull request
Oct 16, 2025
…llm-project#26470) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: bbartels <benjamin@bartels.dev>
lywa1998
pushed a commit
to lywa1998/vllm
that referenced
this pull request
Oct 20, 2025
…llm-project#26470) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
alhridoy
pushed a commit
to alhridoy/vllm
that referenced
this pull request
Oct 24, 2025
…llm-project#26470) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…llm-project#26470) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi
pushed a commit
to 0xrushi/vllm
that referenced
this pull request
Oct 26, 2025
…llm-project#26470) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman
pushed a commit
to rtourgeman/vllm
that referenced
this pull request
Nov 10, 2025
…llm-project#26470) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
devpatelio
pushed a commit
to SumanthRH/vllm
that referenced
this pull request
Nov 29, 2025
…llm-project#26470) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix #26194
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.