Skip to content

Cleanup basic and entrypoint test organisation#31228

Closed
hmellor wants to merge 8 commits intovllm-project:mainfrom
hmellor:cleanup-entrypoints-2
Closed

Cleanup basic and entrypoint test organisation#31228
hmellor wants to merge 8 commits intovllm-project:mainfrom
hmellor:cleanup-entrypoints-2

Conversation

@hmellor
Copy link
Member

@hmellor hmellor commented Dec 23, 2025

Supersedes #27747:

  • Don't call basic test files individually
  • Move the unit tests into a unit directory so we don't have to manually ignore everything else
  • Move openai/tool_parsers into the unit tests because that's what they are

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@mergify mergify bot added ci/build llama Related to Llama models labels Dec 23, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides a good cleanup of the entrypoint tests. The main changes involve reorganizing test files into a new tests/entrypoints/unit directory, which improves the test structure by separating unit tests. The CI pipeline configuration in .buildkite/test-pipeline.yaml has been updated to reflect these changes, simplifying the test execution commands. Another notable improvement is in test_collective_rpc.py, where a manual GPU check is replaced with a pytest.mark.multi_gpu_test decorator, which is a cleaner approach. Overall, these changes enhance maintainability and clarity. I have not identified any issues of high or critical severity.

@hmellor hmellor changed the title Cleanup-entrypoints-2 Cleanup basic and entrypoint test organisation Dec 23, 2025
@hmellor hmellor marked this pull request as ready for review December 23, 2025 18:10
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

Copy link
Collaborator

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

@chaunceyjiang chaunceyjiang added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 24, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from To Triage to Ready in gpt-oss Issues & Enhancements Dec 24, 2025
@hmellor
Copy link
Member Author

hmellor commented Jan 27, 2026

Closing as this is now too stale

@hmellor hmellor closed this Jan 27, 2026
@hmellor hmellor deleted the cleanup-entrypoints-2 branch January 27, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build gpt-oss Related to GPT-OSS models llama Related to Llama models ready ONLY add when PR is ready to merge/full CI is needed tool-calling

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants