Cleanup basic and entrypoint test organisation#31228
Cleanup basic and entrypoint test organisation#31228hmellor wants to merge 8 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request provides a good cleanup of the entrypoint tests. The main changes involve reorganizing test files into a new tests/entrypoints/unit directory, which improves the test structure by separating unit tests. The CI pipeline configuration in .buildkite/test-pipeline.yaml has been updated to reflect these changes, simplifying the test execution commands. Another notable improvement is in test_collective_rpc.py, where a manual GPU check is replaced with a pytest.mark.multi_gpu_test decorator, which is a cleaner approach. Overall, these changes enhance maintainability and clarity. I have not identified any issues of high or critical severity.
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
82bd9c5 to
d5a0405
Compare
|
Closing as this is now too stale |
Supersedes #27747:
unitdirectory so we don't have to manually ignore everything elseopenai/tool_parsersinto theunittests because that's what they are