[CI] Replace large models with tiny alternatives in tests#24057
[CI] Replace large models with tiny alternatives in tests#24057hmellor merged 27 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
…tests Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
2af99d5 to
1749e88
Compare
|
After further consideration, I've removed the pre-commit check from the Buildkite pipeline. Since the pre-commit checks already run on GitHub Actions (and it's way faster), I think it'd be simpler to just let Buildkite run only after GitHub's pre-commit validation passes. Perhaps we can configure Buildkite to skip builds with failing commit status, or use branch protection to enforce this order. Not related to this PR, though. Earlier, I added the pre-commit check to Buildkite since it was a relatively small change and addressed #23452, but now I think there are better ways to handle this. |
|
Thanks @tahsintunan! Re any changes to the pre-commit flow, it would be good to keep in separate PRs (I know that's maybe n/a now since you reverted it). |
njhill
left a comment
There was a problem hiding this comment.
Thanks @tahsintunan, looks great! It may overlap slightly with other PRs e.g. #23896, but I think that's fine, we can just try to get them all merged quicky.
We were hoping to standardize on hmellor/tiny-random-LlamaForCausalLM as the small model, do you think you could update the PR to use that?
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
|
@njhill Hey! I've updated the PR to use
Edit: |
…ion mismatch Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
d87a998 to
8527a62
Compare
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
@tahsintunan could you please look into the remaining failures? |
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Head branch was pushed to by a user without write access
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
|
@hmellor All failures are fixed |
hmellor
left a comment
There was a problem hiding this comment.
All the other changes LGTM, just one question about test_shutdown.py
…ct#24057) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Nick Hill <nhill@redhat.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
|
Thanks a lot @tahsintunan @hmellor! |
…ct#24057) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Nick Hill <nhill@redhat.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…ct#24057) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Nick Hill <nhill@redhat.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…ct#24057) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Nick Hill <nhill@redhat.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…ct#24057) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Nick Hill <nhill@redhat.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…ct#24057) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Nick Hill <nhill@redhat.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
…ct#24057) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Nick Hill <nhill@redhat.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
…ct#24057) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Nick Hill <nhill@redhat.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
…ct#24057) Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com> Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Co-authored-by: Nick Hill <nhill@redhat.com> Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Purpose
This PR replaces large language Llama models with tiny alternatives in test files to reduce CI execution time.
Key changes:
EleutherAI/pythia-14m,JackFram/llama-68m) models.test_shutdown,test_basic_correctness,test_sampling_params_e2e)Test Plan
Ran the following (modified) tests and had them all pass.