Skip to content

[CI] Replace large models with tiny alternatives in tests#24057

Merged
hmellor merged 27 commits intovllm-project:mainfrom
tahsintunan:ci-tiny-models
Oct 16, 2025
Merged

[CI] Replace large models with tiny alternatives in tests#24057
hmellor merged 27 commits intovllm-project:mainfrom
tahsintunan:ci-tiny-models

Conversation

@tahsintunan
Copy link
Contributor

@tahsintunan tahsintunan commented Sep 1, 2025

Purpose

This PR replaces large language Llama models with tiny alternatives in test files to reduce CI execution time.

Key changes:

  • Replace big (>1B) meta-llama models with smaller (e.g., EleutherAI/pythia-14m, JackFram/llama-68m) models.
  • Refactor some test implementations (e.g., test_shutdown, test_basic_correctness, test_sampling_params_e2e)

Test Plan

Ran the following (modified) tests and had them all pass.

# Basic Correctness Tests
pytest -xvs tests/basic_correctness/test_basic_correctness.py
pytest -xvs tests/basic_correctness/test_cpu_offload.py
pytest -xvs tests/basic_correctness/test_cumem.py

# Distributed Tests (Requires multiple GPUs)
pytest -xvs tests/distributed/test_sequence_parallel.py
pytest -xvs tests/entrypoints/llm/test_collective_rpc.py

# API Tests
pytest -xvs tests/entrypoints/openai/test_shutdown.py
pytest -xvs tests/entrypoints/openai/test_run_batch.py
pytest -xvs tests/entrypoints/openai/test_serving_models.py

# Sampling Tests
pytest -xvs tests/samplers/test_ignore_eos.py
pytest -xvs tests/samplers/test_no_bad_words.py

# V1 Tests
VLLM_USE_V1=1 pytest -xvs tests/v1/sample/test_sampling_params_e2e.py
VLLM_USE_V1=1 pytest -xvs tests/v1/core/test_scheduler_e2e.py
VLLM_USE_V1=1 pytest -xvs tests/v1/engine/test_engine_core.py
VLLM_USE_V1=1 pytest -xvs tests/v1/shutdown/test_delete.py
VLLM_USE_V1=1 pytest -xvs tests/v1/shutdown/test_forward_error.py
VLLM_USE_V1=1 pytest -xvs tests/v1/shutdown/test_startup_error.py

Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
…tests

Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
@github-actions
Copy link

github-actions bot commented Sep 1, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@tahsintunan tahsintunan changed the title Ci tiny models [CI] Replace large models with tiny alternatives in tests Sep 1, 2025
@tahsintunan tahsintunan marked this pull request as ready for review September 1, 2025 21:34
@robertgshaw2-redhat robertgshaw2-redhat added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 1, 2025
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
@tahsintunan
Copy link
Contributor Author

tahsintunan commented Sep 2, 2025

After further consideration, I've removed the pre-commit check from the Buildkite pipeline. Since the pre-commit checks already run on GitHub Actions (and it's way faster), I think it'd be simpler to just let Buildkite run only after GitHub's pre-commit validation passes. Perhaps we can configure Buildkite to skip builds with failing commit status, or use branch protection to enforce this order.

Not related to this PR, though. Earlier, I added the pre-commit check to Buildkite since it was a relatively small change and addressed #23452, but now I think there are better ways to handle this.

@njhill
Copy link
Member

njhill commented Sep 2, 2025

Thanks @tahsintunan! Re any changes to the pre-commit flow, it would be good to keep in separate PRs (I know that's maybe n/a now since you reverted it).

Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tahsintunan, looks great! It may overlap slightly with other PRs e.g. #23896, but I think that's fine, we can just try to get them all merged quicky.

We were hoping to standardize on hmellor/tiny-random-LlamaForCausalLM as the small model, do you think you could update the PR to use that?

@tahsintunan
Copy link
Contributor Author

tahsintunan commented Sep 2, 2025

@njhill Hey! I've updated the PR to use hmellor/tiny-random-LlamaForCausalLM where possible. Couldn't replace it in 3 tests due to specific requirements:

  • test_sequence_parallel - No decoder-only support
  • test_no_bad_words - Doesn't have add_prefix_space tokenizer support
  • test_basic_correctness - tokenization mismatches when using prompt embeddings (missing whitespace)

Edit: hmellor/tiny-random-LlamaForCausalLM also doesn't work with TP and SP

@tahsintunan tahsintunan requested a review from njhill September 2, 2025 20:35
…ion mismatch

Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
@mergify mergify bot removed the needs-rebase label Oct 8, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
@hmellor hmellor enabled auto-merge (squash) October 8, 2025 10:13
@hmellor
Copy link
Member

hmellor commented Oct 8, 2025

@tahsintunan could you please look into the remaining failures?

@mergify
Copy link

mergify bot commented Oct 14, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @tahsintunan.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Oct 14, 2025
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
auto-merge was automatically disabled October 14, 2025 13:39

Head branch was pushed to by a user without write access

@mergify mergify bot removed the needs-rebase label Oct 14, 2025
Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
@tahsintunan
Copy link
Contributor Author

@hmellor All failures are fixed

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other changes LGTM, just one question about test_shutdown.py

@hmellor hmellor merged commit 43721bc into vllm-project:main Oct 16, 2025
31 checks passed
albertoperdomo2 pushed a commit to albertoperdomo2/vllm that referenced this pull request Oct 16, 2025
…ct#24057)

Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Nick Hill <nhill@redhat.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Alberto Perdomo <aperdomo@redhat.com>
@njhill
Copy link
Member

njhill commented Oct 16, 2025

Thanks a lot @tahsintunan @hmellor!

@tahsintunan tahsintunan deleted the ci-tiny-models branch October 16, 2025 20:36
Zhuul pushed a commit to Zhuul/vllm that referenced this pull request Oct 17, 2025
…ct#24057)

Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Nick Hill <nhill@redhat.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
BoyuanFeng pushed a commit to BoyuanFeng/vllm that referenced this pull request Oct 17, 2025
…ct#24057)

Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Nick Hill <nhill@redhat.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
lywa1998 pushed a commit to lywa1998/vllm that referenced this pull request Oct 20, 2025
…ct#24057)

Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Nick Hill <nhill@redhat.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
alhridoy pushed a commit to alhridoy/vllm that referenced this pull request Oct 24, 2025
…ct#24057)

Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Nick Hill <nhill@redhat.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
…ct#24057)

Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Nick Hill <nhill@redhat.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
0xrushi pushed a commit to 0xrushi/vllm that referenced this pull request Oct 26, 2025
…ct#24057)

Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Nick Hill <nhill@redhat.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: 0xrushi <6279035+0xrushi@users.noreply.github.com>
rtourgeman pushed a commit to rtourgeman/vllm that referenced this pull request Nov 10, 2025
…ct#24057)

Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Nick Hill <nhill@redhat.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
devpatelio pushed a commit to SumanthRH/vllm that referenced this pull request Nov 29, 2025
…ct#24057)

Signed-off-by: Tahsin Tunan <tahsintunan@gmail.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Nick Hill <nhill@redhat.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants