OnlineDDL in v12: remove legacy code deprecated in earlier version#8972
Merged
shlomi-noach merged 3 commits intovitessio:release-12.0from Oct 21, 2021
Merged
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
added
Type: Enhancement
3 tasks
deepthi
reviewed
Oct 11, 2021
Collaborator
There was a problem hiding this comment.
We should add a note to https://github.com/vitessio/vitess/blob/release-12.0/doc/releasenotes/12_0_0_summary.md about the removal.
Otherwise LGTM
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Author
|
Added release notes. |
deepthi
approved these changes
Oct 20, 2021
This was referenced Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8971
Description
Context: #6926 (comment)
Followup to #8414
The commands
vtctl OnlineDDL revertandvtctl VExecare removed in this PR. Inv11we already showed a deprecation warning to users, so we are now good for full removal.VExeccode will be subsequently completely removed (it's still being used internally byvtctl, and we will first change that internal behavior).Checklist