restore 'vtctl VExec' command (main branch)#9228
Merged
shlomi-noach merged 3 commits intovitessio:mainfrom Nov 17, 2021
Merged
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
added
Type: Bug
Component: Cluster management
release notes (needs details)
deepthi
approved these changes
Nov 17, 2021
Collaborator
deepthi
left a comment
deepthi
left a comment
There was a problem hiding this comment.
Looks good.
Can you revert the change to the release notes file and then merge?
Comment on lines
-34
to
-35
| The command `vtctl VExec` is deprecated and removed. All Online DDL commands should run through `vtctl OnlineDDL`. | ||
|
|
Collaborator
There was a problem hiding this comment.
These are the release notes that shipped with 12.0.0. Since that is out the door we should not change them.
In 12.0.1 we can write new release notes that we are undo-ing the deprecation.
3 tasks
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
added
release notes
and removed
release notes (needs details)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9193
Followup to #8972
Backport PR: #9227
This PR restores
vtctl VExecfunctionality. It was removed based on the assumption the only uses for this command were for Online DDL command. This was wrong, and VExec is also used as a wrapper around VReplication.For now, we restore the full functionality, although we intend to deprecate use of VExec for Online DDL. See some discussion in #8972
Checklist
cc @deepthi @hallaroo @mattlord