Skip to content

OnlineDDL in v12: remove legacy code deprecated in earlier version#8971

Merged
shlomi-noach merged 4 commits intovitessio:mainfrom
planetscale:v12-deprecate-onlineddl-vexec
Oct 20, 2021
Merged

OnlineDDL in v12: remove legacy code deprecated in earlier version#8971
shlomi-noach merged 4 commits intovitessio:mainfrom
planetscale:v12-deprecate-onlineddl-vexec

Conversation

@shlomi-noach
Copy link
Copy Markdown
Contributor

Description

Context: #6926 (comment)
Followup to #8414

The commands vtctl OnlineDDL revert and vtctl VExec are removed in this PR. In v11 we already showed a deprecation warning to users, so we are now good for full removal.

VExec code will be subsequently completely removed (it's still being used internally by vtctl, and we will first change that internal behavior).

Checklist

  • Should this PR be backported? - yes, backporting to release 12
  • Tests were added or are not required
  • Documentation was added or is not required

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Copy Markdown
Contributor Author

Backport to release-12.0: #8972

Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Copy Markdown
Contributor Author

Added release notes.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach merged commit d7f0034 into vitessio:main Oct 20, 2021
@shlomi-noach shlomi-noach deleted the v12-deprecate-onlineddl-vexec branch October 20, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants