restore 'vtctl VExec' command, remove Onlind DDL VExec functionality (main branch)#9226
Closed
shlomi-noach wants to merge 2 commits intovitessio:mainfrom
Closed
restore 'vtctl VExec' command, remove Onlind DDL VExec functionality (main branch)#9226shlomi-noach wants to merge 2 commits intovitessio:mainfrom
shlomi-noach wants to merge 2 commits intovitessio:mainfrom
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
added
Type: Bug
Component: Cluster management
Backport me!
Component: VReplication
release notes (needs details)
shlomi-noach
requested review from
ajm188,
deepthi,
doeg,
harshit-gangal,
rohit-nayak-ps and
systay
as code owners
Contributor
Author
|
Heh. Not so fast. |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Author
|
OK, further dependency resolved. |
shlomi-noach
added a commit
to vitessio/website
that referenced
this pull request
Nov 14, 2021
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Contributor
Author
|
Ugh sorry, yet another dependency in |
Contributor
Author
|
This gets more complicated. I need to think about this some more. |
Contributor
Author
|
For now I'm going to close this PR and create a new PR which merely reverts #8972, until I figure out the best way to deprecate VExec/OnlineDDL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #9193
Followup to #8972
Backport PR: #9225
This PR restores
vtctl VExecfunctionality. It was removed based on the assumption the only uses for this command were for Online DDL command. This was wrong, and VExec is also used as a wrapper around VReplication.This PR now re-enabled
vtctl VExec, but then strips out any Online DDL -specific logic from VExec. This means removing theschema_migrationstable references, planner, templates; demotingonlineddl.Executorfrom being aVExec-utor, and removing some boilerplate code.Checklist
cc @deepthi @hallaroo