Fix minor upgrade logic in go upgrade tool #19176
Merged
Conversation
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
d56f06b to
95fb1cb
Compare
In #18402, logic was added to make sure that patch versions are considered for upgrades, but this had the unintended effect of making non-major version upgrades stop working. This fixes that and also additionally adds a stricter check for existing PRs in the workflow. Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
95fb1cb to
91d6d9d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19176 +/- ##
==========================================
+ Coverage 69.91% 69.92% +0.01%
==========================================
Files 1613 1613
Lines 216122 216126 +4
==========================================
+ Hits 151097 151126 +29
+ Misses 65025 65000 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mattlord
approved these changes
Jan 20, 2026
1 task
nickvanw
approved these changes
Jan 24, 2026
mhamza15
added a commit
to mhamza15/vitess
that referenced
this pull request
Jan 24, 2026
mhamza15
added a commit
to mhamza15/vitess
that referenced
this pull request
Jan 24, 2026
mhamza15
added a commit
to mhamza15/vitess
that referenced
this pull request
Jan 24, 2026
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
mhamza15
added a commit
to mhamza15/vitess
that referenced
this pull request
Jan 24, 2026
mhamza15
added a commit
to mhamza15/vitess
that referenced
this pull request
Jan 24, 2026
Signed-off-by: Mohamed Hamza <mhamza@fastmail.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #18402, logic was added to make sure that patch versions are considered for upgrades, but this had the unintended effect of making non-major version upgrades stop working. This fixes that and also additionally adds a stricter check for existing PRs in the workflow.
Related Issue(s)
Checklist
Deployment Notes
AI Disclosure