Skip to content

[release-19.0] Release of v19.0.0#15359

Merged
systay merged 10 commits intorelease-19.0from
release-19.0-create-release-2
Mar 6, 2024
Merged

[release-19.0] Release of v19.0.0#15359
systay merged 10 commits intorelease-19.0from
release-19.0-create-release-2

Conversation

@systay
Copy link
Copy Markdown
Collaborator

@systay systay commented Feb 26, 2024

Includes the release notes and release commit for the v19.0.0 release. Once this PR is merged, we will be able to tag v19.0.0 on the merge commit.

@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Feb 26, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@systay systay mentioned this pull request Feb 26, 2024
38 tasks
@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Feb 26, 2024
@github-actions github-actions bot added this to the v19.0.0 milestone Feb 26, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.43%. Comparing base (977b585) to head (32bbed9).
Report is 4 commits behind head on release-19.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #15359      +/-   ##
================================================
- Coverage         67.43%   67.43%   -0.01%     
================================================
  Files              1560     1560              
  Lines            192581   192642      +61     
================================================
+ Hits             129858   129899      +41     
- Misses            62723    62743      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Feb 26, 2024
@frouioui frouioui force-pushed the release-19.0-create-release-2 branch from 2ea57d3 to 015fe93 Compare March 4, 2024 15:18
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation level changed in error?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I am seeing it doesn't affect the format on GitHub.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing space added in error?

systay added 3 commits March 4, 2024 14:19
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
frouioui added 3 commits March 4, 2024 14:19
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui frouioui force-pushed the release-19.0-create-release-2 branch from 50036e8 to af547d6 Compare March 4, 2024 20:20
@frouioui
Copy link
Copy Markdown
Member

frouioui commented Mar 4, 2024

Rebased #15401.

systay added 4 commits March 5, 2024 15:44
…0-create-release-2

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
…0-create-release-2

Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay merged commit 97fdf78 into release-19.0 Mar 6, 2024
@systay systay deleted the release-19.0-create-release-2 branch March 6, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: General Changes throughout the code base Type: Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants