Skip to content

[release-19.0] prevent vtctld from creating tons of S3 connections (#15296)#15401

Merged
frouioui merged 1 commit intorelease-19.0from
backport-15296-to-release-19.0
Mar 4, 2024
Merged

[release-19.0] prevent vtctld from creating tons of S3 connections (#15296)#15401
frouioui merged 1 commit intorelease-19.0from
backport-15296-to-release-19.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot bot commented Mar 4, 2024

Description

This is a backport of #15296

Signed-off-by: Renan Rangel <rrangel@slack-corp.com>
Signed-off-by: 'Renan Rangel' <rrangel@slack-corp.com>
@vitess-bot vitess-bot bot requested a review from deepthi as a code owner March 4, 2024 19:32
@vitess-bot vitess-bot bot added the Backport This is a backport label Mar 4, 2024
@vitess-bot vitess-bot bot requested a review from mattlord as a code owner March 4, 2024 19:32
@vitess-bot vitess-bot bot added Component: General Changes throughout the code base Type: Performance labels Mar 4, 2024
@vitess-bot vitess-bot bot requested a review from rvrangel March 4, 2024 19:32
@vitess-bot
Copy link
Copy Markdown
Contributor Author

vitess-bot bot commented Mar 4, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v19.0.0 milestone Mar 4, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.44%. Comparing base (977b585) to head (2c59593).
Report is 1 commits behind head on release-19.0.

Files Patch % Lines
go/vt/mysqlctl/s3backupstorage/s3.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #15401      +/-   ##
================================================
+ Coverage         67.43%   67.44%   +0.01%     
================================================
  Files              1560     1560              
  Lines            192581   192632      +51     
================================================
+ Hits             129858   129924      +66     
+ Misses            62723    62708      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui merged commit da09dc8 into release-19.0 Mar 4, 2024
@frouioui frouioui deleted the backport-15296-to-release-19.0 branch March 4, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport This is a backport Component: General Changes throughout the code base Type: Performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants