Skip to content

[release-19.0] VtctldClient Reshard: add e2e tests to confirm CLI options and fix discovered issues. (#15353)#15364

Merged
rohit-nayak-ps merged 1 commit intorelease-19.0from
backport-15353-to-release-19.0
Feb 26, 2024
Merged

[release-19.0] VtctldClient Reshard: add e2e tests to confirm CLI options and fix discovered issues. (#15353)#15364
rohit-nayak-ps merged 1 commit intorelease-19.0from
backport-15353-to-release-19.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot bot commented Feb 26, 2024

Description

This is a backport of #15353

…scovered issues. (#15353)

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor Author

vitess-bot bot commented Feb 26, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v19.0.0 milestone Feb 26, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 67.40%. Comparing base (c46d4b1) to head (3b10b91).

Files Patch % Lines
go/vt/vtctl/workflow/server.go 0.00% 8 Missing ⚠️
...tctldclient/command/vreplication/reshard/create.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #15364      +/-   ##
================================================
- Coverage         67.44%   67.40%   -0.04%     
================================================
  Files              1560     1560              
  Lines            192384   192390       +6     
================================================
- Hits             129759   129689      -70     
- Misses            62625    62701      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohit-nayak-ps rohit-nayak-ps merged commit b2291f6 into release-19.0 Feb 26, 2024
@rohit-nayak-ps rohit-nayak-ps deleted the backport-15353-to-release-19.0 branch February 26, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants