Skip to content

[release-19.0] [vtctldclient] Add GetShardReplication (#15389)#15390

Merged
frouioui merged 1 commit intorelease-19.0from
backport-15389-to-release-19.0
Mar 4, 2024
Merged

[release-19.0] [vtctldclient] Add GetShardReplication (#15389)#15390
frouioui merged 1 commit intorelease-19.0from
backport-15389-to-release-19.0

Conversation

@vitess-bot
Copy link
Copy Markdown
Contributor

@vitess-bot vitess-bot bot commented Feb 29, 2024

Description

This is a backport of #15389

Signed-off-by: Andrew Mason <andrew@planetscale.com>
@vitess-bot
Copy link
Copy Markdown
Contributor Author

vitess-bot bot commented Feb 29, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v19.0.0 milestone Feb 29, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 67.42%. Comparing base (977b585) to head (aad6ebc).

Files Patch % Lines
go/cmd/vtctldclient/command/shards.go 5.26% 18 Missing ⚠️
go/vt/vtctl/grpcvtctldclient/client_gen.go 0.00% 4 Missing ⚠️
go/vt/vtctl/localvtctldclient/client_gen.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-19.0   #15390      +/-   ##
================================================
- Coverage         67.43%   67.42%   -0.01%     
================================================
  Files              1560     1560              
  Lines            192581   192629      +48     
================================================
+ Hits             129858   129873      +15     
- Misses            62723    62756      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deepthi deepthi mentioned this pull request Mar 1, 2024
38 tasks
@frouioui frouioui merged commit 283b5c2 into release-19.0 Mar 4, 2024
@frouioui frouioui deleted the backport-15389-to-release-19.0 branch March 4, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants