CI: Move all ubuntu-18.04 to ubuntu-20.04#11026
CI: Move all ubuntu-18.04 to ubuntu-20.04#11026deepthi wants to merge 1 commit intovitessio:mainfrom
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
Probably good to define a specific version so we don't have to scramble if Actions changes With |
Signed-off-by: deepthi <deepthi@planetscale.com>
39d1856 to
4576c43
Compare
|
Hmm, is the |
|
We also seem to have some other stuff that might now run against MySQL 8.0 and not 5.7? That looks very much like an issue where on MySQL 5.7 integer lengths are still printed for a schema, but that doesn't happen anymore for MySQL 8.0. |
On MySQL 8.0 it's possible we get back a zero length state for session state changed information. In this case, we treat this as no data being present and continue. This was exposed in vitessio#11026 but I'm extracted this as a separate fix until that lands since this can trigger spurious errors when it shouldn't. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
On MySQL 8.0 it's possible we get back a zero length state for session state changed information. In this case, we treat this as no data being present and continue. This was exposed in #11026 but I'm extracted this as a separate fix until that lands since this can trigger spurious errors when it shouldn't. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Extracted from vitessio#11026 to move CI to 20.04 for the tabletmanager CI jobs. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Extracted from vitessio#11026 Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
This is extracted from vitessio#11026 Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Extracted from #11026 to move CI to 20.04 for the tabletmanager CI jobs. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
* Upgrade CI for unit tests to Ubuntu 20.04 Extracted from #11026 Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Fix MySQL installation Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
This is extracted from #11026 Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Extracted from vitessio#11026 Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
|
Some parts of this have already been picked out and merged, and #11153 handles the rest. Hence, closing. |
Description
Ideally we should run on
ubuntu-latestbut let's see if this works first.Related Issue(s)
Checklist
Deployment Notes