Fix handling zero byte string for session state changed#11071
Merged
vmg merged 1 commit intovitessio:mainfrom Aug 23, 2022
Merged
Fix handling zero byte string for session state changed#11071vmg merged 1 commit intovitessio:mainfrom
vmg merged 1 commit intovitessio:mainfrom
Conversation
On MySQL 8.0 it's possible we get back a zero length state for session state changed information. In this case, we treat this as no data being present and continue. This was exposed in vitessio#11026 but I'm extracted this as a separate fix until that lands since this can trigger spurious errors when it shouldn't. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
Contributor
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
vmg
approved these changes
Aug 23, 2022
notfelineit
pushed a commit
to planetscale/vitess
that referenced
this pull request
Sep 21, 2022
…) (vitessio#996) On MySQL 8.0 it's possible we get back a zero length state for session state changed information. In this case, we treat this as no data being present and continue. This was exposed in vitessio#11026 but I'm extracted this as a separate fix until that lands since this can trigger spurious errors when it shouldn't. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MySQL 8.0 it's possible we get back a zero length state for session state changed information. In this case, we treat this as no data being present and continue.
This was exposed in #11026 but I'm extracted this as a separate fix until that lands since this can trigger spurious errors when it shouldn't.
Related Issue(s)
Found through #11026 where we have a test failed fixed by this change:
Checklist