Skip to content

Upgrade CI for unit tests to Ubuntu 20.04#11119

Merged
frouioui merged 2 commits intovitessio:mainfrom
planetscale:dbussink/upgrade-unit-test-ci
Aug 30, 2022
Merged

Upgrade CI for unit tests to Ubuntu 20.04#11119
frouioui merged 2 commits intovitessio:mainfrom
planetscale:dbussink/upgrade-unit-test-ci

Conversation

@dbussink
Copy link
Copy Markdown
Member

Extracted from #11026

Related Issue(s)

#11026

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

@vitess-bot
Copy link
Copy Markdown
Contributor

vitess-bot bot commented Aug 30, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@dbussink dbussink force-pushed the dbussink/upgrade-unit-test-ci branch from a24428d to 11fc860 Compare August 30, 2022 10:17
Extracted from vitessio#11026

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink force-pushed the dbussink/upgrade-unit-test-ci branch 2 times, most recently from 98c6486 to 91f885c Compare August 30, 2022 11:55
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@dbussink dbussink force-pushed the dbussink/upgrade-unit-test-ci branch from 91f885c to 5645793 Compare August 30, 2022 12:14
@frouioui frouioui merged commit 8c7d460 into vitessio:main Aug 30, 2022
@frouioui frouioui deleted the dbussink/upgrade-unit-test-ci branch August 30, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants