Skip to content

Upgrade vtorc CI#11124

Closed
dbussink wants to merge 1 commit intovitessio:mainfrom
dbussink:upgrade-vtorc-ci
Closed

Upgrade vtorc CI#11124
dbussink wants to merge 1 commit intovitessio:mainfrom
dbussink:upgrade-vtorc-ci

Conversation

@dbussink
Copy link
Member

Extracted from #11026

Related Issue(s)

#11026

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Extracted from vitessio#11026

Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Aug 30, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@dbussink
Copy link
Member Author

dbussink commented Sep 1, 2022

Closing this as it's not correct, since we now would run things twice against MySQL 8.0. Instead, we should do #11153

@dbussink dbussink closed this Sep 1, 2022
@dbussink dbussink deleted the upgrade-vtorc-ci branch September 1, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant