Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag#10701
Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag#10701mattlord merged 12 commits intovitessio:mainfrom
Conversation
Signed-off-by: Matt Lord <mattalord@gmail.com>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Bug fixes
Non-trivial changes
New/Existing features
Backward compatibility
|
GuptaManan100
left a comment
There was a problem hiding this comment.
Looks good to me! We might have to remove the mysql_server_version being set in some tests that are currently doing it because we now do it in this central place.
Signed-off-by: Matt Lord <mattalord@gmail.com>
I pushed another commit removing any other place we used a static string in the endtoend tests: c5cf717 If it causes tests failures then I'll either revert that or investigate and fix the failures. |
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
vmg
left a comment
There was a problem hiding this comment.
I like this approach, a lot of the engine/planner tests have always been written for 8.0 and porting them to 5.7 right before 5.7 is EOL seems wasteful.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…vitessio#10701) * Auto detect MySQL version and use in vtgate --mysql_server_version flag Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove any explicit static usage of mysql_server_version Signed-off-by: Matt Lord <mattalord@gmail.com> * The reservedconns test needs to override the mysql_server_version Signed-off-by: Matt Lord <mattalord@gmail.com> * Explicitly allow overriding the mysql_system_version Signed-off-by: Matt Lord <mattalord@gmail.com> * minimize diff Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix vitessio#10712 Signed-off-by: Matt Lord <mattalord@gmail.com> * Use more robust string comparisons Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix collation handling in tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix tm_init_test Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix more unit tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Another test fix Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix another test that requires 8.0 collations Signed-off-by: Matt Lord <mattalord@gmail.com>
…er_version Flag (#10733) * Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag (#10701) * Auto detect MySQL version and use in vtgate --mysql_server_version flag Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove any explicit static usage of mysql_server_version Signed-off-by: Matt Lord <mattalord@gmail.com> * The reservedconns test needs to override the mysql_server_version Signed-off-by: Matt Lord <mattalord@gmail.com> * Explicitly allow overriding the mysql_system_version Signed-off-by: Matt Lord <mattalord@gmail.com> * minimize diff Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix #10712 Signed-off-by: Matt Lord <mattalord@gmail.com> * Use more robust string comparisons Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix collation handling in tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix tm_init_test Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix more unit tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Another test fix Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix another test that requires 8.0 collations Signed-off-by: Matt Lord <mattalord@gmail.com> * Kick the CI :-| Signed-off-by: Matt Lord <mattalord@gmail.com>
Description
We were using the default value for the vtgate
--mysql_server_versionflag of 5.7.9-vitess even when the tests were using MySQL 8.0. This work auto detects the MySQL version that will be used for the tests and uses that in the vtgate--mysql_server_versionflag unless a specificmysql_server_versionhas been specified for the test. This way we retain the ability to use custom values for this flag when needed, while otherwise defaulting to a reasonable version.This will allow us to move more tests to MySQL 8.0 in a seamless way over the coming months as 5.7 is slated for EOL in October, 2023.
Backport to: release-14.0label.Related Issue(s)
SELECT CAST("test" AS CHAR(60))#10712Checklist