Skip to content

[release-14.0] Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag#10733

Merged
mattlord merged 2 commits intovitessio:release-14.0from
planetscale:backport-10701-to-release-14.0
Jul 20, 2022
Merged

[release-14.0] Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag#10733
mattlord merged 2 commits intovitessio:release-14.0from
planetscale:backport-10701-to-release-14.0

Conversation

@mattlord
Copy link
Member

@mattlord mattlord commented Jul 18, 2022 •
edited
Loading

Description

This is a backport of #10701.

ℹ️ NOTE: this patch was already approved in #10730, but the automated backport process was failing on the git ref for the push triggered workflows.

Related Issue(s)

Checklist

  • "Backport me!" label has been added if this change should be backported
  • Tests were added or are not required
  • Documentation was added or is not required

@mattlord
Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag (…
6ce3576 
…vitessio#10701)

* Auto detect MySQL version and use in vtgate --mysql_server_version flag

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Remove any explicit static usage of mysql_server_version

Signed-off-by: Matt Lord <mattalord@gmail.com>

* The reservedconns test needs to override the mysql_server_version

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Explicitly allow overriding the mysql_system_version

Signed-off-by: Matt Lord <mattalord@gmail.com>

* minimize diff

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Fix vitessio#10712

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Use more robust string comparisons

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Fix collation handling in tests

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Fix tm_init_test

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Fix more unit tests

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Another test fix

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Fix another test that requires 8.0 collations

Signed-off-by: Matt Lord <mattalord@gmail.com>
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Jul 18, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

@mattlord mattlord changed the title Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag… [release-14.0] Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag… Jul 18, 2022
@mattlord mattlord changed the title [release-14.0] Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag… [release-14.0] Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag Jul 18, 2022
frouioui
frouioui approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😀

@mattlord
Kick the CI :-|
46a31f0 
Signed-off-by: Matt Lord <mattalord@gmail.com>
@mattlord mattlord merged commit a9ce80c into vitessio:release-14.0 Jul 20, 2022
@mattlord mattlord deleted the backport-10701-to-release-14.0 branch July 20, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frouioui frouioui frouioui approved these changes

@deepthi deepthi Awaiting requested review from deepthi

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach shlomi-noach is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees

No one assigned

Labels

Backport This is a backport Component: Build/CI Component: Query Serving Type: Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattlord @frouioui