Skip to content

[release-14.0] Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag (#10701)#10730

Closed
vitess-bot[bot] wants to merge 12 commits intorelease-14.0from
backport-10701-to-release-14.0
Closed

[release-14.0] Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag (#10701)#10730
vitess-bot[bot] wants to merge 12 commits intorelease-14.0from
backport-10701-to-release-14.0

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Jul 18, 2022

Description

This is a backport of #10701.

mattlord added 12 commits July 15, 2022 06:00
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
Signed-off-by: Matt Lord <mattalord@gmail.com>
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Jul 18, 2022

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
  • If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
  • If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

  • There should be at least one unit or end-to-end test.
  • The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

  • There should be some code comments as to why things are implemented the way they are.

New/Existing features

  • Should be documented, either by modifying the existing documentation or creating new documentation.
  • New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • vtctl command output order should be stable and awk-able.

Copy link
Member

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @frouioui ! 😃

@mattlord
Copy link
Member

The push/commit triggered workflows are failing:

Get current git ref
[22](https://github.com/vitessio/vitess/runs/7393547649?check_suite_focus=true#step:3:23)
  /usr/bin/git branch --show-current
[23](https://github.com/vitessio/vitess/runs/7393547649?check_suite_focus=true#step:3:24)
  cherry-pick-backport-10701-to-release-14.0-ca47afff-a997-42bd-a97e-65edb7fb4564
[24](https://github.com/vitessio/vitess/runs/7393547649?check_suite_focus=true#step:3:26)
Changes will be detected between main and cherry-pick-backport-10701-to-release-14.0-ca47afff-a997-42bd-a97e-65edb7fb4564
[25](https://github.com/vitessio/vitess/runs/7393547649?check_suite_focus=true#step:3:27)
Searching for merge-base main...cherry-pick-backport-10701-to-release-14.0-ca47afff-a997-42bd-a97e-65edb7fb4564
[26](https://github.com/vitessio/vitess/runs/7393547649?check_suite_focus=true#step:3:28)
  /usr/bin/git show-ref main
[27](https://github.com/vitessio/vitess/runs/7393547649?check_suite_focus=true#step:3:29)
  /usr/bin/git show-ref cherry-pick-backport-10701-to-release-14.0-ca47afff-a997-42bd-a97e-65edb7fb4564
[28](https://github.com/vitessio/vitess/runs/7393547649?check_suite_focus=true#step:3:30)
  f8cf9c2d882ff04934f5b2772406a4008714dc5e refs/heads/cherry-pick-backport-10701-to-release-14.0-ca47afff-a997-42bd-a97e-65edb7fb4564
[29](https://github.com/vitessio/vitess/runs/7393547649?check_suite_focus=true#step:3:31)
  f8cf9c2d882ff04934f5b2772406a4008714dc5e refs/remotes/origin/cherry-pick-backport-10701-to-release-14.0-ca47afff-a997-42bd-a97e-65edb7fb4564
[30](https://github.com/vitessio/vitess/runs/7393547649?check_suite_focus=true#step:3:32)
  /usr/bin/git fetch --no-tags --depth=100 origin main cherry-pick-backport-10701-to-release-14.0-ca47afff-a997-42bd-a97e-65edb7fb4564
[31](https://github.com/vitessio/vitess/runs/7393547649?check_suite_focus=true#step:3:33)
  fatal: couldn't find remote ref cherry-pick-backport-10701-to-release-14.0-ca47afff-a997-42bd-a97e-65edb7fb4564
[32](https://github.com/vitessio/vitess/runs/7393547649?check_suite_focus=true#step:3:35)
Error: The process '/usr/bin/git' failed with exit code 128

I will close this auto generated one and create a new one manually.

@mattlord mattlord closed this Jul 18, 2022
@mattlord mattlord deleted the backport-10701-to-release-14.0 branch July 18, 2022 17:12
@frouioui frouioui restored the backport-10701-to-release-14.0 branch August 25, 2022 23:50
@frouioui frouioui reopened this Aug 25, 2022
@frouioui frouioui closed this Aug 26, 2022
@frouioui frouioui deleted the backport-10701-to-release-14.0 branch August 26, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants