Add MySQL 8 Support to Backup Tests by mattlord · Pull Request #10691 · vitessio/vitess

mattlord · 2022-07-13T16:15:17Z

Description

This PR does the following:

Modifies the MySQL 8.0 CI workflow template to use the Percona apt repo instead of the MySQL one
- This then aligns the mysqld and xtrabackup versions
- xtrabackup 8.0.28 is latest and does not support mysqld 8.0.29, which is the latest server version upstream
Adds explicit MySQL 8.0 and XtraBackup 8.0 support to the relevant endtoend backup tests
- The tar stream specific tests are skipped as those are not supported in XtraBackup 8.0
Creates a new (xb_backup) mysql80 workflow to test XtraBackup 8.0 with MySQL 8.0
Renames the test shard/workflow "19" to the more meaningful "vtbackup_transform"
Modifies how the xtrabackup related tests run with 5.7 so that the only tests done (not skipped) are the tar stream specific ones
- Meaning that the xbstream and vtctlbackup tests are only done with 8.0
- This is because while XtraBackup 2.4 defaults to using the tar stream method, XtraBackup 8.0 does not have a tar stream method, only xbstream

Related Issue(s)

Checklist

"Backport me!" label has been added if this change should be backported
Tests were added or are not required
Documentation was added or is not required

vitess-bot · 2022-07-13T16:15:19Z

Signed-off-by: Matt Lord <mattalord@gmail.com>

This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. Signed-off-by: Matt Lord <mattalord@gmail.com>

Signed-off-by: Matt Lord <mattalord@gmail.com>

…sions Signed-off-by: Matt Lord <mattalord@gmail.com>

Signed-off-by: Matt Lord <mattalord@gmail.com>

rsajwani · 2022-07-14T00:58:58Z

changes looks good. These are precisely all the issues I encounter on my local box. Thanks for fixing them.

Signed-off-by: Matt Lord <mattalord@gmail.com>

deepthi

Nice work @mattlord, thank you for taking this on.
I'm a little iffy about changing ALL 8.0 tests to use percona. I would prefer to do that only for the xtrabackup test clusters.

deepthi · 2022-07-20T18:21:15Z

go/mysql/collations/tools/makecolldata/contractions.go

 		}
 		if depth == len(cont.Path) {
-			leaf = &cont
+			leaf = &cont // nolint:exportloopref


This was fixed in #10765, so we should remove the nolint directive.

Thanks! I'll remove and rebase.

Nice work @mattlord, thank you for taking this on.
I'm a little iffy about changing ALL 8.0 tests to use percona. I would prefer to do that only for the xtrabackup test clusters.

I don't see a problem with it. Percona 8.0 has little changes beyond upstream as most of the patches that were in 5.7 and before (especially 5.6 and 5.5) are now no longer relevant. I also like that we're testing what I think many of our users are using. But I understand the concern.

I can make this change in only the XtraBackup workflows though. I'll just need to create a separate template for them and handle them specially in the generator. If you feel strongly about it then I'll do that.

In that case, this LGTM

Here's a patch we can leverage if we do decide to change this decision in the future and limit Percona Server 8.0 usage to XtraBackup tests: https://gist.github.com/mattlord/341fc54e4fa3f36d11bd03d8bdf57124

* Add support for MySQL 8.0 in backup tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Add 8.0 workflow Signed-off-by: Matt Lord <mattalord@gmail.com> * whitespace Signed-off-by: Matt Lord <mattalord@gmail.com> * Use vtctldclient SetKeyspaceDurabilityPolicy to manage semi-sync This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove extraneous changes Signed-off-by: Matt Lord <mattalord@gmail.com> * We need lz4 for TestXtrabackupStreamWithlz4Compression Signed-off-by: Matt Lord <mattalord@gmail.com> * Try using Percona Repo for MySQL 8 to align mysqld and xtrabackup versions Signed-off-by: Matt Lord <mattalord@gmail.com> * Specify stream type everywhere Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove repeated server install Signed-off-by: Matt Lord <mattalord@gmail.com> * Moar... Signed-off-by: Matt Lord <mattalord@gmail.com> * Move vtctlbackup test to 8.0 Signed-off-by: Matt Lord <mattalord@gmail.com> * Rename vtbackup test and move to MySQL 8 Signed-off-by: Matt Lord <mattalord@gmail.com> * Split the xbstream tests so the workflow doesn't time out Otherwise it was going over the 10min limit and getting killed. Signed-off-by: Matt Lord <mattalord@gmail.com> * Use MySQL 8 compat method for setting passwords Signed-off-by: Matt Lord <mattalord@gmail.com> * Test increasing timeout at another level Signed-off-by: Matt Lord <mattalord@gmail.com> * Don't use the init passwords file with 8.0 mysqlctl doesn't start... This is likely due to the change in initialization behavior with MySQL 8.0 as it goes though two phases and you can't simply start up mysqld and pass it data, it has to initialize and restart first. Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix incorrect password update statement for vt_repl user Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Bump timeouts for 8.0 backup tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Bump it more :( Signed-off-by: Matt Lord <mattalord@gmail.com> * Increase backup/restore timeout in backup_utils Signed-off-by: Matt Lord <mattalord@gmail.com> * Apply new 8.0 template everywhere Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix bugs around how the compression flags were getting passed Signed-off-by: Matt Lord <mattalord@gmail.com> * Use 45m timeout for the workflow, 30m for the run. Signed-off-by: Matt Lord <mattalord@gmail.com> * These changes were no longer needed so limiting diff. Signed-off-by: Matt Lord <mattalord@gmail.com> * Explicitly skip new linter check Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>

…test + compressors (#119) * Delete all legacy sharding related code (vitessio#10278) * Delete all legacy sharding related code Signed-off-by: Matt Lord <mattalord@gmail.com> * Move used until functions from initialsharding to cluster Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove vtctl commands Signed-off-by: Matt Lord <mattalord@gmail.com> * Kill vtworker and SetKeyspaceServedFrom cmd Signed-off-by: Matt Lord <mattalord@gmail.com> * WaitForDrain related stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Legacy local straggler workflow Signed-off-by: Matt Lord <mattalord@gmail.com> * Get rid of SetKeyspaceShardingInfo & wait for drain stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove vtworker stragglers Signed-off-by: Matt Lord <mattalord@gmail.com> * Update throttlerservice protobuf Signed-off-by: Matt Lord <mattalord@gmail.com> * Rename test 24, add hashicorp vault test to it (now mysql_server_vault) Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove last mentiones of legacy sharding in vtctl Signed-off-by: Matt Lord <mattalord@gmail.com> * remove binlog_use_v3_resharding_mode Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Correct vtgate help output Signed-off-by: Matt Lord <mattalord@gmail.com> * go fmt Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove v2 resharding fields (vitessio#10409) * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * generate vtadmin files Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * cleanup: remove sharding_column_name and sharding_column_type from vtadmin Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * Merge from main Signed-off-by: Arvind Murty <arvind.murty@gmail.com> * Fix bad merge conflict resolution Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix missing 'sharding' import Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bad conflict resolution in go/test/endtoend/cellalias/cell_alias_test.go Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Backup/Restore: add support for external compressors and decompressors (vitessio#10558) * change to support an external decompressor Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add external compressor support + builtin additional compressors Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * wrap external compressor/decompressor Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * go mod tidy + comments Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add copyright notices Signed-off-by: Renan Rangel <renan@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * add support for builtin engine Signed-off-by: Renan Rangel <rrangel@slack-corp.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Adding test case for buckup compression Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing unit test and run mod tidy Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Removing unwanted unit tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Increase timeout of backup tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing linter errors Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Change test logic to accomodate running selective tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * removing lint warning Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing test failure Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Removing un-necessary test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing code review feeback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Change builtinEngine to consider 'auto' decompressor Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing Upgrade/Downgrade test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fix type & add summary under release notes Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing typos in summary Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing flag name typos Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com> * Add MySQL 8 Support to Backup Tests (vitessio#10691) * Add support for MySQL 8.0 in backup tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Add 8.0 workflow Signed-off-by: Matt Lord <mattalord@gmail.com> * whitespace Signed-off-by: Matt Lord <mattalord@gmail.com> * Use vtctldclient SetKeyspaceDurabilityPolicy to manage semi-sync This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove extraneous changes Signed-off-by: Matt Lord <mattalord@gmail.com> * We need lz4 for TestXtrabackupStreamWithlz4Compression Signed-off-by: Matt Lord <mattalord@gmail.com> * Try using Percona Repo for MySQL 8 to align mysqld and xtrabackup versions Signed-off-by: Matt Lord <mattalord@gmail.com> * Specify stream type everywhere Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove repeated server install Signed-off-by: Matt Lord <mattalord@gmail.com> * Moar... Signed-off-by: Matt Lord <mattalord@gmail.com> * Move vtctlbackup test to 8.0 Signed-off-by: Matt Lord <mattalord@gmail.com> * Rename vtbackup test and move to MySQL 8 Signed-off-by: Matt Lord <mattalord@gmail.com> * Split the xbstream tests so the workflow doesn't time out Otherwise it was going over the 10min limit and getting killed. Signed-off-by: Matt Lord <mattalord@gmail.com> * Use MySQL 8 compat method for setting passwords Signed-off-by: Matt Lord <mattalord@gmail.com> * Test increasing timeout at another level Signed-off-by: Matt Lord <mattalord@gmail.com> * Don't use the init passwords file with 8.0 mysqlctl doesn't start... This is likely due to the change in initialization behavior with MySQL 8.0 as it goes though two phases and you can't simply start up mysqld and pass it data, it has to initialize and restart first. Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix incorrect password update statement for vt_repl user Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Bump timeouts for 8.0 backup tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Bump it more :( Signed-off-by: Matt Lord <mattalord@gmail.com> * Increase backup/restore timeout in backup_utils Signed-off-by: Matt Lord <mattalord@gmail.com> * Apply new 8.0 template everywhere Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix bugs around how the compression flags were getting passed Signed-off-by: Matt Lord <mattalord@gmail.com> * Use 45m timeout for the workflow, 30m for the run. Signed-off-by: Matt Lord <mattalord@gmail.com> * These changes were no longer needed so limiting diff. Signed-off-by: Matt Lord <mattalord@gmail.com> * Explicitly skip new linter check Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> * Fix test file merge issues Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Go 1.18.7 to fix error Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix lint Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix vttablet.txt Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove sharding_column_name and sharding_column_type from vtctld2 (vitessio#10459) * Remove sharding_column_name and sharding_column_type Signed-off-by: notfelineit <notfelineit@gmail.com> * Run make web_build to compile production files Signed-off-by: notfelineit <notfelineit@gmail.com> * Remove vars from test Signed-off-by: notfelineit <notfelineit@gmail.com> * Remove sharding column type select box test from web test Signed-off-by: notfelineit <notfelineit@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Arvind Murty <arvind.murty@gmail.com> Signed-off-by: notfelineit <notfelineit@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Arvind Murty <arvind.murty@gmail.com> Co-authored-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Frances Thai <31225471+notfelineit@users.noreply.github.com>

…test + compressors (#119) (#124) * Delete all legacy sharding related code (vitessio#10278) * Delete all legacy sharding related code * Move used until functions from initialsharding to cluster * Remove vtctl commands * Kill vtworker and SetKeyspaceServedFrom cmd * WaitForDrain related stragglers * Legacy local straggler workflow * Get rid of SetKeyspaceShardingInfo & wait for drain stragglers * Remove vtworker stragglers * Update throttlerservice protobuf * Rename test 24, add hashicorp vault test to it (now mysql_server_vault) * Remove last mentiones of legacy sharding in vtctl * remove binlog_use_v3_resharding_mode * Address review comments * Address review comments * Correct vtgate help output * go fmt * Remove v2 resharding fields (vitessio#10409) * cleanup: remove sharding_column_name and sharding_column_type * cleanup: remove sharding_column_name and sharding_column_type * cleanup: remove sharding_column_name and sharding_column_type * cleanup: remove sharding_column_name and sharding_column_type * generate vtadmin files * cleanup: remove sharding_column_name and sharding_column_type from vtadmin * Merge from main * Fix bad merge conflict resolution * Fix missing 'sharding' import * Fix bad conflict resolution in go/test/endtoend/cellalias/cell_alias_test.go * Backup/Restore: add support for external compressors and decompressors (vitessio#10558) * change to support an external decompressor * add external compressor support + builtin additional compressors * wrap external compressor/decompressor * go mod tidy + comments * add copyright notices * add support for builtin engine * Adding test case for buckup compression * Fixing unit test and run mod tidy * Removing unwanted unit tests * Increase timeout of backup tests * fixing linter errors * Change test logic to accomodate running selective tests * removing lint warning * fixing test failure * Removing un-necessary test * Fixing code review feeback * Change builtinEngine to consider 'auto' decompressor * fixing Upgrade/Downgrade test * Fix type & add summary under release notes * Fixing typos in summary * Fixing flag name typos * Add MySQL 8 Support to Backup Tests (vitessio#10691) * Add support for MySQL 8.0 in backup tests * Add 8.0 workflow * whitespace * Use vtctldclient SetKeyspaceDurabilityPolicy to manage semi-sync This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. * Remove extraneous changes * We need lz4 for TestXtrabackupStreamWithlz4Compression * Try using Percona Repo for MySQL 8 to align mysqld and xtrabackup versions * Specify stream type everywhere * Remove repeated server install * Moar... * Move vtctlbackup test to 8.0 * Rename vtbackup test and move to MySQL 8 * Split the xbstream tests so the workflow doesn't time out Otherwise it was going over the 10min limit and getting killed. * Use MySQL 8 compat method for setting passwords * Test increasing timeout at another level * Don't use the init passwords file with 8.0 mysqlctl doesn't start... This is likely due to the change in initialization behavior with MySQL 8.0 as it goes though two phases and you can't simply start up mysqld and pass it data, it has to initialize and restart first. * Fix incorrect password update statement for vt_repl user * Bump timeouts for 8.0 backup tests * Bump it more :( * Increase backup/restore timeout in backup_utils * Apply new 8.0 template everywhere * Fix bugs around how the compression flags were getting passed * Use 45m timeout for the workflow, 30m for the run. * These changes were no longer needed so limiting diff. * Explicitly skip new linter check * Fix test file merge issues * Go 1.18.7 to fix error * Fix lint * Fix vttablet.txt * Remove sharding_column_name and sharding_column_type from vtctld2 (vitessio#10459) * Remove sharding_column_name and sharding_column_type * Run make web_build to compile production files * Remove vars from test * Remove sharding column type select box test from web test --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Arvind Murty <arvind.murty@gmail.com> Signed-off-by: notfelineit <notfelineit@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Arvind Murty <arvind.murty@gmail.com> Co-authored-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Renan Rangel <rrangel@slack-corp.com> Co-authored-by: Renan Rangel <renan@slack-corp.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Frances Thai <31225471+notfelineit@users.noreply.github.com>

mattlord force-pushed the xb_backup_e2e_mysql8 branch from 12eac9d to 0e08e04 Compare July 13, 2022 16:34

mattlord requested a review from rsajwani July 13, 2022 16:40

mattlord force-pushed the xb_backup_e2e_mysql8 branch from 0e08e04 to ae3b5e8 Compare July 13, 2022 17:07

Add support for MySQL 8.0 in backup tests

d759ab7

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the xb_backup_e2e_mysql8 branch from ae3b5e8 to d759ab7 Compare July 13, 2022 19:18

Add 8.0 workflow

e9fa25b

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord added Component: Build/CI release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) Type: Internal Cleanup Type: CI/Build and removed Type: Internal Cleanup labels Jul 13, 2022

whitespace

e88c8b7

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord removed the release notes (needs details) This PR needs to be listed in the release notes in a dedicated section (deprecation notice, etc...) label Jul 13, 2022

mattlord requested review from GuptaManan100 and deepthi July 13, 2022 22:18

mattlord added 2 commits July 13, 2022 18:26

Use vtctldclient SetKeyspaceDurabilityPolicy to manage semi-sync

90ca126

This needed to be done after the shard was setup in order to satisfy the semantic assumptions related to semi-sync in the tests. Signed-off-by: Matt Lord <mattalord@gmail.com>

Remove extraneous changes

d808cd2

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord changed the base branch from main to release-14.0 July 13, 2022 22:41

mattlord changed the base branch from release-14.0 to main July 13, 2022 22:45

mattlord added 2 commits July 13, 2022 19:08

We need lz4 for TestXtrabackupStreamWithlz4Compression

64e0c06

Signed-off-by: Matt Lord <mattalord@gmail.com>

Try using Percona Repo for MySQL 8 to align mysqld and xtrabackup ver…

2182980

…sions Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the xb_backup_e2e_mysql8 branch from 908226f to 2182980 Compare July 14, 2022 00:21

mattlord added 2 commits July 13, 2022 20:41

Specify stream type everywhere

d104ad2

Signed-off-by: Matt Lord <mattalord@gmail.com>

Remove repeated server install

da5a08d

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord changed the title ~~Add xb_backup mysql 8 workflow with new mysql 8 backup test support~~ Add MySQL 8 support to backup tests Jul 14, 2022

Moar...

b379bbc

Signed-off-by: Matt Lord <mattalord@gmail.com>

Move vtctlbackup test to 8.0

c73ecf5

Signed-off-by: Matt Lord <mattalord@gmail.com>

rsajwani approved these changes Jul 14, 2022

View reviewed changes

Bump timeouts for 8.0 backup tests

bc96897

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord force-pushed the xb_backup_e2e_mysql8 branch from a0bcfeb to bc96897 Compare July 14, 2022 14:09

mattlord added the Backport to: release-14.0 label Jul 14, 2022

mattlord added 3 commits July 14, 2022 10:49

Bump it more :(

0ff6fd0

Signed-off-by: Matt Lord <mattalord@gmail.com>

Increase backup/restore timeout in backup_utils

94cd963

Signed-off-by: Matt Lord <mattalord@gmail.com>

Apply new 8.0 template everywhere

7e2c847

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord removed the Backport to: release-14.0 label Jul 14, 2022

mattlord added 3 commits July 14, 2022 18:47

Fix bugs around how the compression flags were getting passed

a91130b

Signed-off-by: Matt Lord <mattalord@gmail.com>

Use 45m timeout for the workflow, 30m for the run.

eeee707

Signed-off-by: Matt Lord <mattalord@gmail.com>

These changes were no longer needed so limiting diff.

0c9303d

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord marked this pull request as ready for review July 14, 2022 23:48

mattlord requested a review from rohit-nayak-ps July 14, 2022 23:53

mattlord changed the title ~~Add MySQL 8 support to backup tests~~ Add MySQL 8 Support to Backup Tests Jul 15, 2022

mattlord mentioned this pull request Jul 15, 2022

Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag #10701

Merged

3 tasks

mattlord removed the Do Not Merge label Jul 18, 2022

mattlord added 3 commits July 20, 2022 00:13

Merge branch 'main' into xb_backup_e2e_mysql8

2c6bced

Merge remote-tracking branch 'origin/main' into xb_backup_e2e_mysql8

3197594

Signed-off-by: Matt Lord <mattalord@gmail.com>

Explicitly skip new linter check

5ab4af7

Signed-off-by: Matt Lord <mattalord@gmail.com>

mattlord requested review from harshit-gangal and systay as code owners July 20, 2022 14:52

deepthi reviewed Jul 20, 2022

View reviewed changes

deepthi approved these changes Jul 20, 2022

View reviewed changes

deepthi merged commit bf13249 into vitessio:main Jul 20, 2022

deepthi deleted the xb_backup_e2e_mysql8 branch July 20, 2022 19:54

mattlord mentioned this pull request Aug 2, 2022

Backups: Support InnoDB Redo Log Location With 8.0.30+ #10847

Merged

3 tasks

timvaillancourt mentioned this pull request Aug 17, 2023

slack-vitess-r14.0.5: remove legacy sharding, add MySQL 8.x backup test + compressors slackhq/vitess#119

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add MySQL 8 Support to Backup Tests#10691

Add MySQL 8 Support to Backup Tests#10691
deepthi merged 27 commits intovitessio:mainfrom
planetscale:xb_backup_e2e_mysql8

mattlord commented Jul 13, 2022 •

edited

Loading

Uh oh!

vitess-bot bot commented Jul 13, 2022 •

edited

Loading

Uh oh!

rsajwani commented Jul 14, 2022 •

edited

Loading

Uh oh!

deepthi left a comment

Uh oh!

deepthi Jul 20, 2022

Uh oh!

mattlord Jul 20, 2022

Uh oh!

mattlord Jul 20, 2022

Uh oh!

deepthi Jul 20, 2022

Uh oh!

mattlord Jul 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mattlord commented Jul 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue(s)

Checklist

Uh oh!

vitess-bot bot commented Jul 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review Checklist

General

Bug fixes

Non-trivial changes

New/Existing features

Backward compatibility

Uh oh!

rsajwani commented Jul 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deepthi left a comment

Choose a reason for hiding this comment

Uh oh!

deepthi Jul 20, 2022

Choose a reason for hiding this comment

Uh oh!

mattlord Jul 20, 2022

Choose a reason for hiding this comment

Uh oh!

mattlord Jul 20, 2022

Choose a reason for hiding this comment

Uh oh!

deepthi Jul 20, 2022

Choose a reason for hiding this comment

Uh oh!

mattlord Jul 20, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mattlord commented Jul 13, 2022 •

edited

Loading

vitess-bot bot commented Jul 13, 2022 •

edited

Loading

rsajwani commented Jul 14, 2022 •

edited

Loading