Skip to content

fix: Stop with tasks when parent exits - #14163

Merged
anthonyshew merged 1 commit into
mainfrom
shew/stop-with-tasks
Sep 22, 2026
Merged

anthonyshew merged 1 commit into
mainfrom
shew/stop-with-tasks

Conversation

@anthonyshew

Copy link
Copy Markdown
Contributor

Summary

  • Stop tasks listed in with after their owning task finishes.
  • Use the existing selective process-manager shutdown path for graceful cleanup.
  • Cover the behavior with an integration test using a finite parent and persistent sidecar.

Behavior

parent task completes
  resolve its `with` task IDs
  ProcessManager::stop_tasks(with_tasks)
    send graceful interrupt
    wait for sidecar cleanup
  finish the run

@anthonyshew
anthonyshew requested review from a team and tknickman September 22, 2026 20:01
@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
examples-basic-web Ready Ready Preview Sep 22, 2026 8:03pm UTC
examples-designsystem-docs Ready Ready Preview Sep 22, 2026 8:03pm UTC
examples-gatsby-web Ready Ready Preview Sep 22, 2026 8:03pm UTC
examples-kitchensink-blog Ready Ready Preview Sep 22, 2026 8:03pm UTC
examples-nonmonorepo Ready Ready Preview Sep 22, 2026 8:03pm UTC
examples-svelte-web Ready Ready Preview Sep 22, 2026 8:03pm UTC
examples-tailwind-web Ready Ready Preview Sep 22, 2026 8:03pm UTC
examples-vite-web Ready Ready Preview Sep 22, 2026 8:03pm UTC
turbo-site Ready Ready Preview Sep 22, 2026 8:03pm UTC
turborepo-factory Ready Ready Preview Sep 22, 2026 8:03pm UTC

Comment thread crates/turborepo-task-graph/src/visitor/mod.rs
@anthonyshew
anthonyshew merged commit fde6637 into main Sep 22, 2026
57 of 59 checks passed
@anthonyshew
anthonyshew deleted the shew/stop-with-tasks branch September 22, 2026 20:16
pull Bot pushed a commit to Dustin4444/turborepo that referenced this pull request Sep 22, 2026
## Release v2.11.3

> [!CAUTION]
> Versioned docs aliasing FAILED. [View
logs](https://github.com/vercel/turborepo/actions/runs/35779237464)

### Changes

- chore: Release Turborepo 2.11.2 (vercel#14107) (`bcc853c`)
- refactor: Remove experimental Cargo compile cache (vercel#14110) (`c14db49`)
- refactor: Remove clap from turborepo-types (vercel#14111) (`1fc6e60`)
- chore: Use canary turbo for Vercel builds (vercel#14112) (`d3b74e7`)
- refactor: Extract turborepo-tracing crate (vercel#14113) (`edc9f82`)
- refactor: Remove Run boundaries extension (vercel#14114) (`18c7be1`)
- refactor: Relocate child spawning to turborepo-process (vercel#14115)
(`5960801`)
- docs: Drop stale support-policy entry from getting-started nav
(vercel#14116) (`4735da1`)
- refactor: Move CLI configuration overrides into CLI (vercel#14119)
(`c61a4cb`)
- fix: Avoid microfrontend polyrepo warnings (vercel#14118) (`530f2eb`)
- refactor: Add run and execution selector DTOs (vercel#14120) (`b730cdb`)
- chore: Release Turborepo 2.11.3-canary.1 (vercel#14121) (`19afae0`)
- test: Reuse Go cache in invalidation test (vercel#14122) (`ba7f8a1`)
- chore: Release Turborepo 2.11.3-canary.2 (vercel#14124) (`cfe2f20`)
- test: Avoid overlapping concurrent cache restores (vercel#14125) (`da00de7`)
- refactor: Rewire Opts to consume selectors (vercel#14126) (`ae55ecc`)
- refactor: Extract task filtering into dedicated crate (vercel#14127)
(`6564345`)
- refactor: Extract task access into dedicated crate (vercel#14128)
(`c12b1f1`)
- refactor: Extract MicrofrontendsConfigs (vercel#14133) (`b5f9880`)
- chore: Update with-rollup example (vercel#14123) (`748aff9`)
- refactor: Move unified turbo.json loader (vercel#14134) (`c031520`)
- refactor: Extract package watcher crate (vercel#14135) (`88c2f90`)
- refactor: Extract prune input DTO (vercel#14136) (`307e2d2`)
- fix: Ignore gitignored files in boundaries (vercel#14137) (`773b3d9`)
- fix: Stabilize boundaries tag order in prune (vercel#14138) (`b64369e`)
- fix: Normalize affected task input globs (vercel#14140) (`00ee364`)
- chore: Release Turborepo 2.11.3-canary.3 (vercel#14141) (`a3b6df8`)
- refactor: Extract prune orchestration (vercel#14142) (`357e766`)
- ci: Update Node.js test matrices (vercel#14139) (`b437bf1`)
- refactor: Add Turborepo run context crate (vercel#14143) (`b8a9a8c`)
- refactor: Add repository run context (vercel#14144) (`1876b23`)
- refactor: Use RepoContext in task graph visitor (vercel#14145) (`a29a419`)
- refactor: Extract repository discovery from run builder (vercel#14146)
(`82031c9`)
- refactor: Extract run execution context construction (vercel#14147)
(`c3efb59`)
- refactor: Extract run services construction (vercel#14148) (`0750df6`)
- refactor: Promote task graph to dedicated crate (vercel#14150) (`d7e061b`)
- refactor: Extract run options into dedicated crate (vercel#14152)
(`fb0a9ec`)
- docs: Remove duplicated word in the 1.9 blog post (vercel#14129) (`3bf6ef8`)
- refactor: Promote run and watch to dedicated crates (vercel#14153)
(`87bccbe`)
- refactor: Extract run command orchestration (vercel#14154) (`1dead3c`)
- refactor: Rename `turborepo-lib` to `turborepo-cli` (vercel#14155)
(`f81062f`)
- refactor: Slim query API interface (vercel#14157) (`5614369`)
- fix(affected): Treat root internal dependency changes as global
(vercel#14156) (`69b7c6b`)
- refactor: Move engine validation into turborepo-engine (vercel#14158)
(`4f23af2`)
- test: Harden weak tests and shared assertion helpers (vercel#14159)
(`ad8379b`)
- chore: Update with-rsbuild-module-federation example (vercel#14160)
(`c079ed3`)
- perf: Reuse parsed lockfile during lazy graph loading (vercel#14161)
(`dd1d31a`)
- chore: Release Turborepo 2.11.3-canary.4 (vercel#14162) (`fb2fb0c`)
- fix: Stop with tasks when parent exits (vercel#14163) (`fde6637`)
- fix: Respect negated global dependencies in affected detection
(vercel#14164) (`83f6d32`)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit that referenced this pull request Sep 25, 2026
## Release v2.11.5-canary.1

> [!CAUTION]
> Versioned docs aliasing FAILED. [View
logs](https://github.com/vercel/turborepo/actions/runs/36081266558)

### Changes

- chore: Release Turborepo 2.11.3-canary.4 (#14162) (`fb2fb0c`)
- fix: Stop with tasks when parent exits (#14163) (`fde6637`)
- fix: Respect negated global dependencies in affected detection
(#14164) (`83f6d32`)
- chore: Release Turborepo 2.11.3 (#14165) (`53629a0`)
- test: Share Go compilation caches across integration tests (#14166)
(`684edb6`)
- refactor: Add injectable manifest loading to repository graphs
(#14167) (`bfa7ee1`)
- test: Move Go and Cargo scope planning into crate tests (#14168)
(`17bed92`)
- refactor: Extract subprocess-free Go observation assembly (#14169)
(`6aa7584`)
- test: Move Cargo environment hash contracts into crates (#14170)
(`417e7b0`)
- test: Move Cargo output layout matrices to repository contracts
(#14171) (`2f5f2ad`)
- test: Cover Go discovery identities in memory (#14172) (`133dfd1`)
- test: Cover Go hash inputs in repository contracts (#14174)
(`bf40164`)
- test: Move uv hash input contracts into crates (#14175) (`4681950`)
- test: Cover Go task selection in the engine (#14173) (`63960c5`)
- test: Inject uv discovery for native task contracts (#14176)
(`22d279f`)
- test: Inject query contracts over repository graphs (#14177)
(`5cef46a`)
- test: Inject dry-run task summary contracts (#14178) (`526b026`)
- test: Expose prune workspace selection plan (#14179) (`a05ba5d`)
- test: Inject change detection at scope entry point (#14180)
(`91bb563`)
- test: Move uv lock affectedness planning into repository contracts
(#14184) (`8976bb8`)
- test: Use virtual clock for package watcher events (#14181)
(`efd2a5b`)
- test: Move Cargo task query and dry-run planning into contracts
(#14185) (`34cad2f`)
- test: Move uv quality query and dry-run projections into contracts
(#14186) (`a895310`)
- test: Move JavaScript hash and framework projections into contracts
(#14188) (`b07c3b7`)
- test: Cover prune closure and native layout plans in process (#14189)
(`1f20198`)
- test: Cover mixed-toolchain scope filters through injection (#14190)
(`a9345fb`)
- test: Make package watcher suppression and rediscovery deterministic
(#14191) (`3c533c3`)
- test: Inject watch run lifecycle and event collection (#14192)
(`cf435db`)
- test: Move recursive root-script guard into process-free contract
(#14193) (`86fc080`)
- test: Move Go query and summary parity into crate contracts (#14187)
(`d5602e6`)
- test: Remove duplicate CLI filter matrix cases (#14194) (`9679df3`)
- test: Trim duplicate prune materialization cases (#14195) (`4f88f0f`)
- test: Match Go library summary path on Windows (#14197) (`03a2700`)
- test: Cover mixed-toolchain watch task selection in process (#14196)
(`6b6a46e`)
- test: Preserve Windows SystemRoot in strict-env fixture (#14198)
(`8d74590`)
- test: Retain real watch smokes after selection migration (#14199)
(`e27a4e7`)
- fix: Only reject secondary `go.work` files Go reads for workspace
members (#14183) (`69cc2c4`)
- test: Split Go north-star cache invalidation into hash contracts
(#14201) (`2441e33`)
- test: Avoid deleting built prune output in cross-toolchain prune test
(#14202) (`a4caf0b`)
- test: Move turbo.json validation cases into crate contracts (#14203)
(`59f0fc3`)
- chore: Update with-solid example (#14200) (`aef1e05`)
- refactor: Split RunBuilder execution context construction into phases
(#14204) (`fb37817`)
- refactor: Inject remote cache status probe (#14205) (`b58b280`)
- refactor: Inject inputs into config resolution (#14206) (`01f1a11`)
- feat: Add affected query APIs to turborepo-query (#14207) (`6b7e675`)
- refactor: Wire CLI through affected query APIs (#14208) (`742fe18`)
- feat: Add pure microfrontend port resolver (#14209) (`7d70cab`)
- refactor: Inject change detection into affected run paths (#14210)
(`6d0afae`)
- test: Move affectedTasks planning cases into query contracts (#14214)
(`7871007`)
- refactor: Route get-mfe-port through the pure resolver (#14215)
(`3826a04`)
- test: Count native discovery for JavaScript-only selections (#14216)
(`4fa1096`)
- fix: Disable remote cache after unrecoverable forbidden responses
(#14218) (`a0a5dff`)
- perf: Send cache analytics in larger batches (#14219) (`96e20b6`)
- perf: Batch dry-run remote cache existence checks (#14220) (`e1ab2d6`)
- test: Move config precedence cases into funnel contracts (#14217)
(`935c9ea`)
- test: Move affected run planning into RunBuilder contracts (#14212)
(`ec329a0`)
- fix: Coordinate artifact requests after rate limiting (#14221)
(`7353b16`)
- fix: Share concurrent remote-cache token recovery (#14223) (`813bed0`)
- refactor: Make repository context inputs injectable (#14224)
(`58a4889`)
- refactor: Group Run state into execution and services contexts
(#14225) (`4b72ac9`)
- test: Move Cargo prune layout checks into in-process plan contracts
(#14226) (`8a9a10a`)
- test: Move Cargo and Go discovery cases into contracts (#14227)
(`4d72915`)
- fix: Put version in `turbo query` JSON output instead of a separate
banner (#14229) (`f74650c`)
- chore: Release Turborepo 2.11.4 (#14231) (`5d2e55f`)
- test: Move Python opt-in hint into filter contracts (#14228)
(`f5b6fea`)
- test: Move dependency-output summary assertion into contract (#14230)
(`3ee0227`)
- test: Move dependency-output selection and validation cases to engine
contracts (#14232) (`9bd011f`)
- test: Move Cargo exclude-only scope coverage (#14238) (`c99ad87`)
- test: Move Cargo cache-authority cases to contracts (#14240)
(`1ad8190`)
- test: Move JIT dependency graph scenario into engine contract (#14235)
(`e427a23`)
- test: Move dependency-output hash cases into task-hash contracts
(#14233) (`c17b62c`)
- test: Move Cargo task-filter cases into crate contracts (#14239)
(`fa6b8db`)
- test: Move JIT input hash timing cases into task-hash contracts
(#14234) (`c928e42`)
- test: Move package input normalization cases into engine contracts
(#14236) (`e6c6d77`)
- test: Move structured startup and JIT input cases into contracts
(#14237) (`a29c843`)
- fix: Back off remote artifact requests during outages (#14222)
(`103d81c`)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
Preview – turborepo-factory — 729fe21f Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant