chore: clean up by chronark · Pull Request #3570 · unkeyed/unkey

chronark · 2025-07-15T14:36:53Z

What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
Enhancement (small improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

Test A
Test B

Checklist

Required

Appreciated

If a UI change was made: Added a screen recording or screenshots to this PR
Updated the Unkey Docs if changes were necessary

vercel · 2025-07-15T14:36:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
dashboard	⬜️ Ignored (Inspect)	Visit Preview		Jul 16, 2025 8:37am
engineering	⬜️ Ignored (Inspect)	Visit Preview		Jul 16, 2025 8:37am

changeset-bot · 2025-07-15T14:36:57Z

⚠️ No Changeset found

Latest commit: 057c5f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-07-15T14:36:59Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

chronark · 2025-07-15T14:37:17Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

chore: clean up #3570 👈 (View in Graphite)
feat: e2e deploy with docker works #3567
feat: docker seems to run #3566
feat: docker backend #3565
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-07-16T08:34:45Z

Thank you for following the naming conventions for pull request titles! 🙏

graphite-app · 2025-07-16T08:36:08Z

graphite-app · 2025-07-16T08:40:11Z

Graphite Automations

"Post a GIF when PR approved" took an action on this PR • (07/16/25)

1 gif was posted to this PR based on Andreas Thomas's automation.

chronark marked this pull request as ready for review July 15, 2025 14:37

chronark requested review from Flo4604, MichaelUnkey, imeyer, mcstepp, ogzhanolguncu and perkinsjr as code owners July 15, 2025 14:37

This was referenced Jul 15, 2025

feat: docker backend #3565

Merged

feat: docker seems to run #3566

Merged

chronark mentioned this pull request Jul 15, 2025

feat: e2e deploy with docker works #3567

Merged

18 tasks

vercel bot temporarily deployed to Preview – engineering July 15, 2025 14:37 Inactive

vercel bot temporarily deployed to Preview – dashboard July 15, 2025 14:37 Inactive

ogzhanolguncu approved these changes Jul 15, 2025

View reviewed changes

chore: clean up

bb7d4a2

chronark force-pushed the 07-15-chore_clean_up branch from b8771bc to bb7d4a2 Compare July 16, 2025 08:34

chronark force-pushed the 07-15-feat_e2e_deploy_with_docker_works branch from 44bda99 to 2e47e5a Compare July 16, 2025 08:34

vercel bot temporarily deployed to Preview – engineering July 16, 2025 08:35 Inactive

vercel bot temporarily deployed to Preview – dashboard July 16, 2025 08:35 Inactive

[autofix.ci] apply automated fixes

057c5f1

Flo4604 merged commit eaf0073 into 07-15-feat_e2e_deploy_with_docker_works Jul 16, 2025
9 checks passed

Flo4604 deleted the 07-15-chore_clean_up branch July 16, 2025 09:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: clean up#3570

chore: clean up#3570
Flo4604 merged 2 commits into07-15-feat_e2e_deploy_with_docker_worksfrom
07-15-chore_clean_up

chronark commented Jul 15, 2025

Uh oh!

vercel bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 15, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

chronark commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 16, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jul 16, 2025

Uh oh!

graphite-app bot commented Jul 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

chronark commented Jul 15, 2025

What does this PR do?

Type of change

How should this be tested?

Checklist

Required

Appreciated

Uh oh!

vercel bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

chronark commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jul 16, 2025

Uh oh!

graphite-app bot commented Jul 16, 2025

Graphite Automations

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Jul 15, 2025 •

edited

Loading

changeset-bot bot commented Jul 15, 2025 •

edited

Loading

coderabbitai bot commented Jul 15, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Jul 16, 2025 •

edited

Loading