feat: docker seems to run by chronark · Pull Request #3566 · unkeyed/unkey

chronark · 2025-07-15T13:33:19Z

What does this PR do?

This PR adds a containerized development environment for Unkey deploy services. It introduces a single Docker container that runs all four deploy services (assetmanagerd, billaged, builderd, metald) with Docker backend instead of VMs for simplified local development.

Key changes:

Added Dockerfile.dev for an all-in-one development container
Created Docker Compose integration in deployment/docker-compose.yaml
Added comprehensive documentation in README.dev.md
Updated service dependencies to use the containerized services
Configured Docker backend for metald (containers instead of VMs)
Added systemd service files for container initialization

Fixes #deploy-local-dev

Type of change

Bug fix (non-breaking change which fixes an issue)
Chore (refactoring code, technical debt, workflow improvements)
Enhancement (small improvements)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How should this be tested?

It ran in docker without crashing, that was the only requirement

Checklist

Required

Appreciated

If a UI change was made: Added a screen recording or screenshots to this PR
Updated the Unkey Docs if changes were necessary

changeset-bot · 2025-07-15T13:33:23Z

⚠️ No Changeset found

Latest commit: a86c954

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2025-07-15T13:33:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2025 8:36am
engineering	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 16, 2025 8:36am

coderabbitai · 2025-07-15T13:33:25Z

Warning

Rate limit exceeded

@chronark has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 15 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between bc104be and a86c954.

⛔ Files ignored due to path filters (1)

go/deploy/metald/go.sum is excluded by !**/*.sum

📒 Files selected for processing (46)

deployment/docker-compose.yaml (2 hunks)
go/deploy/Dockerfile.dev (1 hunks)
go/deploy/README.dev.md (1 hunks)
go/deploy/assetmanagerd/client/client.go (3 hunks)
go/deploy/assetmanagerd/client/types.go (1 hunks)
go/deploy/assetmanagerd/cmd/assetmanagerd-cli/main.go (1 hunks)
go/deploy/assetmanagerd/cmd/assetmanagerd/main.go (2 hunks)
go/deploy/assetmanagerd/internal/builderd/client.go (3 hunks)
go/deploy/assetmanagerd/internal/registry/registry.go (1 hunks)
go/deploy/assetmanagerd/internal/service/service.go (1 hunks)
go/deploy/billaged/client/client.go (3 hunks)
go/deploy/billaged/client/types.go (1 hunks)
go/deploy/billaged/cmd/billaged-cli/main.go (1 hunks)
go/deploy/billaged/cmd/billaged/main.go (2 hunks)
go/deploy/billaged/internal/aggregator/aggregator.go (1 hunks)
go/deploy/billaged/internal/service/billing.go (2 hunks)
go/deploy/builderd/client/client.go (3 hunks)
go/deploy/builderd/client/types.go (1 hunks)
go/deploy/builderd/cmd/builderd-cli/main.go (1 hunks)
go/deploy/builderd/cmd/builderd/main.go (2 hunks)
go/deploy/builderd/internal/assetmanager/client.go (2 hunks)
go/deploy/builderd/internal/assets/base.go (1 hunks)
go/deploy/builderd/internal/executor/docker.go (1 hunks)
go/deploy/builderd/internal/executor/registry.go (1 hunks)
go/deploy/builderd/internal/executor/types.go (1 hunks)
go/deploy/builderd/internal/service/builder.go (1 hunks)
go/deploy/builderd/internal/tenant/isolation.go (1 hunks)
go/deploy/builderd/internal/tenant/manager.go (1 hunks)
go/deploy/builderd/internal/tenant/storage.go (1 hunks)
go/deploy/docker/systemd/assetmanagerd.service (1 hunks)
go/deploy/docker/systemd/billaged.service (1 hunks)
go/deploy/docker/systemd/builderd.service (1 hunks)
go/deploy/docker/systemd/metald.service (1 hunks)
go/deploy/metald/cmd/metald/main.go (2 hunks)
go/deploy/metald/go.mod (4 hunks)
go/deploy/metald/internal/assetmanager/client.go (4 hunks)
go/deploy/metald/internal/assetmanager/client_test.go (1 hunks)
go/deploy/metald/internal/backend/docker/client.go (4 hunks)
go/deploy/metald/internal/backend/docker/metrics.go (7 hunks)
go/deploy/metald/internal/backend/docker/types.go (2 hunks)
go/deploy/metald/internal/backend/firecracker/automatic_build_test.go (1 hunks)
go/deploy/metald/internal/backend/firecracker/sdk_client_v4.go (1 hunks)
go/deploy/metald/internal/backend/firecracker/sdk_client_v4_test.go (1 hunks)
go/deploy/metald/internal/backend/types/backend.go (1 hunks)
go/deploy/metald/internal/billing/client.go (4 hunks)
go/deploy/metald/internal/config/config.go (1 hunks)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

chronark · 2025-07-15T13:33:35Z

chore: clean up #3570
feat: e2e deploy with docker works #3567
feat: docker seems to run #3566 👈 (View in Graphite)
feat: docker backend #3565
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-07-15T14:13:37Z

Thank you for following the naming conventions for pull request titles! 🙏

This was referenced Jul 15, 2025

feat: docker backend #3565

Merged

feat: e2e deploy with docker works #3567

Merged

chronark marked this pull request as ready for review July 15, 2025 13:34

chronark requested review from Flo4604, MichaelUnkey, imeyer, mcstepp, ogzhanolguncu and perkinsjr as code owners July 15, 2025 13:34

vercel bot temporarily deployed to Preview – engineering July 15, 2025 13:35 Inactive

vercel bot temporarily deployed to Preview – dashboard July 15, 2025 13:35 Inactive

ogzhanolguncu self-assigned this Jul 15, 2025

chronark mentioned this pull request Jul 15, 2025

chore: clean up #3570

Merged

18 tasks

Base automatically changed from 07-14-feat_docker_backend to main July 16, 2025 08:32

feat: docker seems to run

a86c954

chronark force-pushed the 07-15-feat_docker_seems_to_run branch from 57d9cf4 to a86c954 Compare July 16, 2025 08:34

vercel bot temporarily deployed to Preview – engineering July 16, 2025 08:36 Inactive

vercel bot temporarily deployed to Preview – dashboard July 16, 2025 08:36 Inactive

chronark merged commit 0c8fd65 into main Jul 16, 2025
27 of 29 checks passed

chronark deleted the 07-15-feat_docker_seems_to_run branch July 16, 2025 09:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: docker seems to run#3566

feat: docker seems to run#3566
chronark merged 1 commit intomainfrom
07-15-feat_docker_seems_to_run

chronark commented Jul 15, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 15, 2025 •

edited

Loading

Rate limit exceeded

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

chronark commented Jul 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

chronark commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Type of change

How should this be tested?

Checklist

Required

Appreciated

Uh oh!

changeset-bot bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

vercel bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

chronark commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chronark commented Jul 15, 2025 •

edited

Loading

changeset-bot bot commented Jul 15, 2025 •

edited

Loading

vercel bot commented Jul 15, 2025 •

edited

Loading

coderabbitai bot commented Jul 15, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

chronark commented Jul 15, 2025 •

edited

Loading

github-actions bot commented Jul 15, 2025 •

edited

Loading