Repositories: Optimize repository caches to populate for both int and GUID keys

[AndyButland]

Summary

• Optimizes DocumentRepository and MediaRepository to populate both the int-keyed and GUID-keyed caches when entities are saved or retrieved
• Previously, retrieving an entity by int ID would not populate the GUID cache (and vice versa), causing unnecessary database hits when the same entity was subsequently accessed by the other key type
• Now, regardless of which identifier type is used to fetch or save an entity, both caches are populated, eliminating redundant database queries

The trigger for this update was some performance analysis done on save and publish comparing 13 to 17. One downside of the newer version is that we are making more use of requests by key now. But still not solely whilst we have the option to request by integer ID as well. This has a downside in that a request by Id followed by a request by Key, or vice versa, would both initially hit the database. With these updates a request for one will cache for the other, meaning a subsequent request either by Id or Key will get a cached response.

Changes

DocumentRepository:

• Override Save() to populate GUID cache after saving
• Modify PerformGet(int) to populate GUID cache after retrieval
• Modify PerformGetAll(int[]) to populate GUID cache after retrieval
• Add PopulateCacheById() methods to populate int cache from GUID lookups
• Modify ContentByGuidReadRepository.PerformGet(Guid) and PerformGetAll(Guid[]) to populate int cache

MediaRepository:

• Same pattern applied as DocumentRepository

Cache key generation:

• Use RepositoryCacheKeys.GetKey<T>() for consistent cache key generation across all cache population methods

Test plan

• Verify Retrievals_By_Id_And_Key_After_Save_Are_Cached passes for both Document and Media repositories
• Verify Retrieval_By_Key_After_Retrieval_By_Id_Is_Cached passes for both repositories
• Verify Retrieval_By_Id_After_Retrieval_By_Key_Is_Cached passes for both repositories
• Verify all existing DocumentRepositoryTest tests pass (30 tests)
• Verify all existing MediaRepositoryTest tests pass (23 tests)

🤖 Generated with Claude Code and human updates.

[Copilot]

Pull request overview

This PR optimizes repository caching for DocumentRepository and MediaRepository by ensuring both int-keyed and GUID-keyed caches are populated whenever entities are saved or retrieved. Previously, fetching by int ID would only populate the int cache, and fetching by GUID would only populate the GUID cache, leading to redundant database queries when the same entity was accessed using a different key type.

Key changes:

• Added dual cache population logic to Save(), PerformGet(), and PerformGetAll() methods in both repositories
• Refactored existing cache tests into three comprehensive scenarios that verify caching works correctly for all access patterns
• Updated cache policy classes to use consistent RepositoryCacheKeys.GetKey<T>() helper method

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
DocumentRepositoryTest.cs	Refactored cache test into three separate tests that verify caching after save, retrieval by ID→Key, and retrieval by Key→ID
MediaRepositoryTest.cs	Refactored cache test into three separate tests that verify caching after save, retrieval by ID→Key, and retrieval by Key→ID
DocumentRepository.cs	Added Save() override and modified PerformGet()/PerformGetAll() to populate both int and GUID caches; added PopulateCacheById() helper methods
MediaRepository.cs	Added Save() override and modified PerformGet()/PerformGetAll() to populate both int and GUID caches; added PopulateCache() helper methods; removed unused using statement
DefaultRepositoryCachePolicy.cs	Updated to use RepositoryCacheKeys.GetKey<TEntity>() for consistent cache key generation
FullDataSetRepositoryCachePolicy.cs	Updated to use RepositoryCacheKeys.GetKey<TEntity>() for consistent cache key generation

Comments suppressed due to low confidence (4)

src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DocumentRepository.cs:264

• The fully qualified namespace Core.Persistence.Repositories.RepositoryCacheKeys is unnecessary since using Umbraco.Cms.Core.Persistence.Repositories; is already declared at line 15. For consistency with the rest of the PR (lines 1652, 1756), this should be simplified to just RepositoryCacheKeys.

                    IsolatedCache.GetCacheItem<IContent>(RepositoryCacheKeys.GetKey<IContent, int>(dto.NodeId));

src/Umbraco.Infrastructure/Persistence/Repositories/Implement/DocumentRepository.cs:1407

• The fully qualified namespace Core.Persistence.Repositories.RepositoryCacheKeys is unnecessary since using Umbraco.Cms.Core.Persistence.Repositories; is already declared at line 15. For consistency with the rest of the PR (lines 1652, 1756), this should be simplified to just RepositoryCacheKeys.

        IsolatedCache.ClearByKey(RepositoryCacheKeys.GetKey<IContent, Guid>(entity.Key));

src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:164

• The fully qualified namespace Core.Persistence.Repositories.RepositoryCacheKeys is unnecessary since using Umbraco.Cms.Core.Persistence.Repositories; is already declared at line 13. For consistency with the rest of the PR (lines 631, 735), this should be simplified to just RepositoryCacheKeys.

                    IsolatedCache.GetCacheItem<IMedia>(RepositoryCacheKeys.GetKey<IMedia, int>(dto.NodeId));

src/Umbraco.Infrastructure/Persistence/Repositories/Implement/MediaRepository.cs:570

• The fully qualified namespace Core.Persistence.Repositories.RepositoryCacheKeys is unnecessary since using Umbraco.Cms.Core.Persistence.Repositories; is already declared at line 13. For consistency with the rest of the PR (lines 631, 735), this should be simplified to just RepositoryCacheKeys.

        IsolatedCache.ClearByKey(RepositoryCacheKeys.GetKey<IMedia, Guid>(entity.Key));

[Zeegaan]

Overall looks good, just a few naming comments 😁 Love the tests too 💪

[Zeegaan]

Looks good to me now 💪