Log viewer: Improves search functionality and code quality

[iOvergaard]

Summary

Refactors the log viewer search functionality to improve code quality and add user-requested features.

Changes:

1. Fix date range fallback - Prevents console errors when dates are missing
2. Replace RxJS Subject with UmbStringState - Resolves TODO by using Umbraco patterns instead of raw RxJS
3. Improve architecture - Move search triggering to the messages list component (data consumer owns fetching)
4. Add refresh button - Allows re-running searches with same query
5. Maintain debouncing - Use local UmbStringState to preserve 250ms debounce on user input

Benefits:

• Prevents unnecessary API calls when not viewing logs
• Better separation of concerns
• Improved user experience by adding a refresh button to the search field, so you can search for the same query again without activating polling

Test Steps

Basic Search Functionality

1. Navigate to Settings → Log Viewer → Search tab
2. Type a search query in the search field
3. Verify search executes after ~250ms of stopping typing (debounced)
4. Verify results appear correctly

Refresh Button

1. Enter a search query and wait for results
2. Click the refresh button (icon-refresh) next to the search field
3. Verify search executes immediately without debounce delay

Saved Searches

1. Enter a search query
2. Click the save button (icon-favorite)
3. Save the search with a name
4. Click on the saved search from the dropdown
5. Verify search executes immediately without debounce

URL Parameters

1. Navigate to the log viewer with URL parameters: ?lq=Error&startDate=2025-11-19&endDate=2025-11-20
2. Verify search criteria are applied from the URL on initial page load
3. Share the URL with the current search - verify it works when others open it

Date Range Handling

1. Navigate to the log viewer without date parameters in the URL
2. Verify default dates (yesterday to today) are applied without console errors

[Copilot]

Pull Request Overview

This PR refactors the log viewer search functionality to improve code quality and user experience. The main achievement is replacing RxJS Subject with the Umbraco-standard UmbStringState pattern, improving architecture by moving search triggering responsibility to the data consumer (messages list), and adding a user-requested refresh button.

Key changes:

• Replaces RxJS Subject with UmbStringState for better alignment with Umbraco patterns
• Moves search triggering logic from input component to messages list component (data consumer owns data fetching)
• Adds refresh button functionality to re-run searches without toggling polling

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
log-viewer-search-input.element.ts	Refactors search input to use UmbStringState for debouncing, removes loader UI, adds refresh button functionality
log-viewer-messages-list.element.ts	Adds observer for filterExpression changes to trigger search when component is mounted and filter changes
log-viewer-date-range-selector.element.ts	Adds nullish coalescing to prevent console errors when dateRange is undefined
log-search-view.element.ts	Adds accessibility attributes (role and aria-label) to search header

[leekelleher]

Tested out, all working as described. 🚀