Fixed location of authoritative repositories

[ligiabernardet]

Fixed location of authoritative repositories. Thank you @junwang-noaa for bringing this up.

[climbfuji]

@ligiabernardet since you are already creating the PR for ufs-weather-model, you might as well do the one for fv3atm with the updated submodule pointers for ccpp-physics and ccpp-framework, and do the same for the updated submodule pointer for fv3atm here.

[ligiabernardet]

I can do this. It will be my first time with nested PRs, so we'll see if I can manage!!

…

On Mon, Mar 30, 2020 at 3:54 PM Dom Heinzeller ***@***.***> wrote: @ligiabernardet <https://github.com/ligiabernardet> since you are already creating the PR for ufs-weather-model, you might as well do the one for fv3atm with the updated submodule pointers for ccpp-physics and ccpp-framework, and do the same for the updated submodule pointer for fv3atm here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#93 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE7WQATOSOYAVDRXTNFT6FTRKEIJZANCNFSM4LXAHBCQ> .

[climbfuji]

I can help a bit.

You can start from your existing PR for the ufs-weather-model and check out the branches that correspond to the PRs for ccpp-framework and ccpp-physics inside fv3atm. A git status will then show you that something has changed in fv3atm. Edit .gitmodules, commend out the existing url= and branch= entries for ccpp-physics and ccpp-framework, add the temporary urls and branches instead. Then commit the change to .gitmodules and the updated submodule pointers for ccpp-framework and ccpp-physics with a commit message saying sth like "Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for code review and testing", create a local branch, push it to GitHub and create the fv3atm PR. Then do the same for fv3atm in ufs-weather-model in your existing PR.

[ligiabernardet]

I updated the submodules. Please see if this worked as it should. Tks.
Associated PRs
NOAA-EMC/ufsatm#90
NCAR/ccpp-physics#420
NCAR/ccpp-framework#274

[junwang-noaa]

GFDL_atmos_cubed_shere in public release is pointing to NOAA-GFDL repo.

[ligiabernardet]

Tks This has been addressed.

[junwang-noaa]

I see line 36 is changed, but line 49 is still listing NOAA-EMC, not NOAA-GFDL.

[climbfuji]

Thanks, Jun. I am going to approve and merge the ccpp-framework and ccpp-physics PRs, then I will ask Ligia to update the submodule pointers in the fv3atm and revert the .gitmodules change.

Oh, after running the tests of course.

[climbfuji]

Regression tests passed on hera.intel, cheyenne.intel, cheyenne.gnu. Will start merging the CCPP PRs.

[climbfuji]

@ligiabernardet The CCPP PRs have been merged. Now you need to use your local working directory from which you created the PRs.

cd FV3/ccpp/framework
git remote update
# assuming that the remote 'origin' points to the NCAR repository
git checkout origin/release/public-v4
cd ../physics
git remote update
# assuming that the remote 'origin' points to the NCAR repository
git checkout origin/release/public-v4
cd ../..
# now you are in directory FV3 and a 'git status' should show you that there are new commits for ccpp/framework and ccpp/physics

Then edit .gitmodules in FV3 and revert the change you made earlier. Then:

git add .gitmodules ccpp/framework ccpp/physics
git commit -m "Revert change to .gitmodules and update submodule pointers for ccpp-framework and ccpp-physics"
git push WHATEVER_YOUR_REMOTE_NAME_IS_LOCALLY doc_updates

We can check if the changes/hashes are ok and Jun can merge the fv3atm PR.

[climbfuji]

@ligiabernardet Now that the fv3atm has been merged you need to do the same for the ufs-weather-model PR. The correct has for fv3atm (i.e. git log in subdirectory FV3) is (the name noaa-emc/release/public-v1 could be different, depending on how you called the NOAA-EMC remote destination locally, I called it noaa-emc):

commit 3b2671b554c3f0a06a369019ba6901f66c6fcb6a (HEAD, noaa-emc/release/public-v1)
Author: ligiabernardet <ligia.bernardet@noaa.gov>
Date:   Tue Mar 31 19:55:55 2020 -0600

    Doc update for public release (submodules ccpp-physics and ccpp-framework) (#90)

    * Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for code review and testing

    * Revert change to .gitmodules and update submodule pointers for ccpp-framework and ccpp-physics

    * Update submodule pointers for CCPP

[ligiabernardet]

The FV3 submodule has been updated.

…

On Wed, Apr 1, 2020 at 6:10 AM Dom Heinzeller ***@***.***> wrote: @ligiabernardet <https://github.com/ligiabernardet> Now that the fv3atm has been merged you need to do the same for the ufs-weather-model PR. The correct has for fv3atm (i.e. git log in subdirectory FV3) is (the name noaa-emc/release/public-v1 could be different, depending on how you called the NOAA-EMC remote destination locally, I called it noaa-emc): commit 3b2671b554c3f0a06a369019ba6901f66c6fcb6a (HEAD, noaa-emc/release/public-v1) Author: ligiabernardet ***@***.***> Date: Tue Mar 31 19:55:55 2020 -0600 Doc update for public release (submodules ccpp-physics and ccpp-framework) (#90) * Update .gitmodules and submodule pointers for ccpp-framework and ccpp-physics for code review and testing * Revert change to .gitmodules and update submodule pointers for ccpp-framework and ccpp-physics * Update submodule pointers for CCPP — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#93 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AE7WQAQITZGJGOR2W2GOOCLRKMVKFANCNFSM4LXAHBCQ> .

[climbfuji]

This looks good to me, thanks. @junwang-noaa @DusanJovic-NOAA whenever it is convenient for you ...