Mg3 rv1#90
Conversation
| @@ -0,0 +1,40 @@ | |||
|
|
|||
There was a problem hiding this comment.
I wonder if there is a possibility to reduce the number of run scripts for these similar tests in the future, i.e. combine some of ccpp_csawmg_run.IN, ccpp_csawmgshoc_run.IN, ccpp_gfsv16_csawmg_run.IN and possibly others. We would need to use some bash if blocks to query which configuration will be run, similar to what is done in ccpp_gsd_run.IN.
| RUN | fv3_ccpp_gsd_debug | standard | | fv3 | | ||
| RUN | fv3_ccpp_thompson_debug | standard | | fv3 | | ||
| RUN | fv3_ccpp_thompson_no_aero_debug | standard | | fv3 | | ||
| ####################################################################################################################################################################################### |
There was a problem hiding this comment.
Future work: when we finally drop the IPD tests, we need to clean up and reorganize the remaining tests.
| ecflow_create_compile_task | ||
| else | ||
| ./compile.sh $PATHTR/FV3 $MACHINE_ID "${NEMS_VER}" $COMPILE_NR > ${LOG_DIR}/compile_${COMPILE_NR}.log 2>&1 | ||
| ./compile.sh $PATHTR/FV3 $MACHINE_ID "${NEMS_VER}" $COMPILE_NR > ${LOG_DIR}/compile_${COMPILE_NR}.log 2>&1 |
There was a problem hiding this comment.
I think this additional whitespace should be removed.
| @@ -0,0 +1,71 @@ | |||
| ############################################################################### | |||
| # | |||
| # FV3 CCPP CSAWMGSHOC test | |||
There was a problem hiding this comment.
This comment does not match the test name.
| @@ -0,0 +1,71 @@ | |||
| ############################################################################### | |||
| # | |||
| # FV3 CCPP CSAWMGSHOC test | |||
There was a problem hiding this comment.
This comment does not match the test name.
| @@ -0,0 +1,72 @@ | |||
| ############################################################################### | |||
| # | |||
| # FV3 CCPP GFDL-MP test | |||
There was a problem hiding this comment.
This comment does not match the test name.
| @@ -0,0 +1,69 @@ | |||
| ############################################################################### | |||
| # | |||
| # FV3 CSAWMG test | |||
There was a problem hiding this comment.
Does this comment match the test name? Or should it contain GFSv16?
| @@ -0,0 +1,69 @@ | |||
| ############################################################################### | |||
| # | |||
| # FV3 CSAWMG test | |||
There was a problem hiding this comment.
This comment does not match the test name.
| @@ -0,0 +1,71 @@ | |||
| ############################################################################### | |||
| # | |||
| # FV3 GFDL-MP test | |||
There was a problem hiding this comment.
This comment does not match the test name.
…cpp_gfsv16_csawmgt fv3_gfsv16_csawmg fv3_gfsv16_csawmgt fv3_gocart_clm
|
Dom:
Yes. It is possible to combine *IN.
Good catch on the comments for the 6 experiments, I have made corresponding
changes and push them to my branch.
Anning
…On Fri, Apr 10, 2020 at 11:16 AM Dom Heinzeller ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In tests/fv3_conf/ccpp_gfsv16_csawmg_run.IN
<#90 (comment)>
:
> @@ -0,0 +1,40 @@
+
I wonder if there is a possibility to reduce the number of run scripts for
these similar tests in the future, i.e. combine some of ccpp_csawmg_run.IN,
ccpp_csawmgshoc_run.IN, ccpp_gfsv16_csawmg_run.IN and possibly others. We
would need to use some bash if blocks to query which configuration will be
run, similar to what is done in ccpp_gsd_run.IN.
------------------------------
In tests/rt.conf
<#90 (comment)>
:
> @@ -396,6 +402,24 @@ COMPILE | CCPP=Y STATIC=Y SUITES=FV3_GSD_v0,FV3_GFS_v15_thompson 32BIT=Y DEBUG=Y
RUN | fv3_ccpp_gsd_debug | standard | | fv3 |
RUN | fv3_ccpp_thompson_debug | standard | | fv3 |
RUN | fv3_ccpp_thompson_no_aero_debug | standard | | fv3 |
+#######################################################################################################################################################################################
Future work: when we finally drop the IPD tests, we need to clean up and
reorganize the remaining tests.
------------------------------
In tests/rt.sh
<#90 (comment)>
:
> @@ -561,7 +561,7 @@ while read -r line; do
elif [[ $ECFLOW == true ]]; then
ecflow_create_compile_task
else
- ./compile.sh $PATHTR/FV3 $MACHINE_ID "${NEMS_VER}" $COMPILE_NR > ${LOG_DIR}/compile_${COMPILE_NR}.log 2>&1
+ ./compile.sh $PATHTR/FV3 $MACHINE_ID "${NEMS_VER}" $COMPILE_NR > ${LOG_DIR}/compile_${COMPILE_NR}.log 2>&1
I think this additional whitespace should be removed.
------------------------------
In tests/tests/fv3_ccpp_gfsv16_csawmg
<#90 (comment)>
:
> @@ -0,0 +1,71 @@
+###############################################################################
+#
+# FV3 CCPP CSAWMGSHOC test
This comment does not match the test name.
------------------------------
In tests/tests/fv3_ccpp_gfsv16_csawmgt
<#90 (comment)>
:
> @@ -0,0 +1,71 @@
+###############################################################################
+#
+# FV3 CCPP CSAWMGSHOC test
This comment does not match the test name.
------------------------------
In tests/tests/fv3_ccpp_gocart_clm
<#90 (comment)>
:
> @@ -0,0 +1,72 @@
+###############################################################################
+#
+# FV3 CCPP GFDL-MP test
This comment does not match the test name.
------------------------------
In tests/tests/fv3_gfsv16_csawmg
<#90 (comment)>
:
> @@ -0,0 +1,69 @@
+###############################################################################
+#
+# FV3 CSAWMG test
Does this comment match the test name? Or should it contain GFSv16?
------------------------------
In tests/tests/fv3_gfsv16_csawmgt
<#90 (comment)>
:
> @@ -0,0 +1,69 @@
+###############################################################################
+#
+# FV3 CSAWMG test
This comment does not match the test name.
------------------------------
In tests/tests/fv3_gocart_clm
<#90 (comment)>
:
> @@ -0,0 +1,71 @@
+###############################################################################
+#
+# FV3 GFDL-MP test
This comment does not match the test name.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#90 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIJUQFHINFAU3MZD7ZLRL4Z5PANCNFSM4LS7IHBQ>
.
|
Thanks for updating the comments in commit 8d79e26. These changes are comments only and do not require rerunning any tests. But we need to figure out what happened to your submodule pointers for fv3atm and ccpp-physics. Were they "wrong" when you ran the tests? Or were they just changed when pushing the latest logs? But how? |
|
Hi, Dom and Dusan:
I have not changed anything for ccpp/physics and fv3atm today. I only
pushed changes on logs and comments. I have no idea on changes made on
ccpp/physics and fv3atm at this point.
Anning
…On Fri, Apr 10, 2020 at 11:49 AM Dom Heinzeller ***@***.***> wrote:
Dom: Yes. It is possible to combine *IN. Good catch on the comments for
the 6 experiments, I have made corresponding changes and push them to my
branch. Anning
… <#m_-8746776033422759130_>
Thanks for updating the comments in commit 8d79e26
<8d79e26>.
These changes are comments only and do not require rerunning any tests.
But we need to figure out what happened to your submodule pointers for
fv3atm and ccpp-physics. Were they "wrong" when you ran the tests? Or were
they just changed when pushing the latest logs? But how?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIJBPIHXWHI2FMLTAA3RL45X5ANCNFSM4LS7IHBQ>
.
|
You made these 3 commits. Each commit changed FV3 submoudule, not just the log files: |
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Looks ok from my side.
|
Thank you! Jun, Dom, Dusan, Moorthi, and all. Have a great weekend and my
best, --Anning
…On Fri, Apr 10, 2020 at 7:18 PM Jun Wang ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#90 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIKWMUSZDHVMBGHEUYLRL6SNXANCNFSM4LS7IHBQ>
.
|
Add README.md file, clean up ush dir, allow any name for top directory
4 participants
In order to resolve the merging conflicts of MG3_v1 with trunk, create MG3_rv1 branch to facilitate merging. MG3_rv1 is the about the same as MG3_v1
Associated PRs:
fv3atm #46
NCAR ccpp/physics #381
#90