SCI doc v4.0 updates#420
Merged
Merged
Conversation
…ional xml files for GFSv15p2 and GFSv16beta
…cean scientific documentation
mzhangw
requested review from
JulieSchramm,
climbfuji,
grantfirl and
llpcarson
as code owners
ligiabernardet
requested changes
Mar 29, 2020
Collaborator
ligiabernardet
left a comment
ligiabernardet
left a comment
There was a problem hiding this comment.
Thanks for the changes. Just a couple things to look at.
Co-Authored-By: ligiabernardet <ligia.bernardet@noaa.gov>
ligiabernardet
approved these changes
Mar 30, 2020
Collaborator
ligiabernardet
left a comment
ligiabernardet
left a comment
There was a problem hiding this comment.
Looks good to me. Pls update the website with the latest version.
Contributor
Author
|
The website is refreshed.
… On Mar 30, 2020, at 2:12 PM, ligiabernardet ***@***.***> wrote:
@ligiabernardet approved this pull request.
Looks good to me. Pls update the website with the latest version.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#420 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2S3SWXZXYXHD4CETGTRKD4JVANCNFSM4LVKYXQQ>.
|
Collaborator
|
Is this PR and NCAR/ccpp-framework#274 ready? If so, I'll go ahead and create the corresponding fv3atm and ufs-weathere-model PRs, and run the tests. |
Contributor
Author
|
#420 is ready.
… On Mar 30, 2020, at 2:49 PM, Dom Heinzeller ***@***.***> wrote:
Is this PR and NCAR/ccpp-framework#274 <NCAR/ccpp-framework#274> ready? If so, I'll go ahead and create the corresponding fv3atm and ufs-weathere-model PRs, and run the tests.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#420 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AG7TW2QWQ5ZKV45IMINVSB3RKEAT5ANCNFSM4LVKYXQQ>.
|
Collaborator
|
It is my understanding that they are ready.
…On Mon, Mar 30, 2020 at 2:49 PM Dom Heinzeller ***@***.***> wrote:
Is this PR and NCAR/ccpp-framework#274
<NCAR/ccpp-framework#274> ready? If so, I'll go
ahead and create the corresponding fv3atm and ufs-weathere-model PRs, and
run the tests.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#420 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE7WQAVNBUWIEGH73WUMN2TRKEAT5ANCNFSM4LVKYXQQ>
.
|
Collaborator
|
Dom, on a second thought... Jun detected an error in the UFS Weather Model
User's Guide. I'd like to do a PR for the public-v1 branch. I can do that
this afternoon.
…On Mon, Mar 30, 2020 at 2:50 PM mzhangw ***@***.***> wrote:
#420 is ready.
> On Mar 30, 2020, at 2:49 PM, Dom Heinzeller ***@***.***>
wrote:
>
>
> Is this PR and NCAR/ccpp-framework#274 <
NCAR/ccpp-framework#274> ready? If so, I'll go
ahead and create the corresponding fv3atm and ufs-weathere-model PRs, and
run the tests.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub <
#420 (comment)>, or
unsubscribe <
https://github.com/notifications/unsubscribe-auth/AG7TW2QWQ5ZKV45IMINVSB3RKEAT5ANCNFSM4LVKYXQQ
>.
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#420 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE7WQAW7RID4EZWMZJ763S3RKEAZBANCNFSM4LVKYXQQ>
.
|
|
I'm done.
On Mon, Mar 30, 2020 at 2:50 PM ligiabernardet <notifications@github.com>
wrote:
… It is my understanding that they are ready.
On Mon, Mar 30, 2020 at 2:49 PM Dom Heinzeller ***@***.***>
wrote:
> Is this PR and NCAR/ccpp-framework#274
> <NCAR/ccpp-framework#274> ready? If so, I'll go
> ahead and create the corresponding fv3atm and ufs-weathere-model PRs, and
> run the tests.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#420 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AE7WQAVNBUWIEGH73WUMN2TRKEAT5ANCNFSM4LVKYXQQ
>
> .
>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#420 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA3WNUZGSKJ4RMJ33UZZZG3RKEA2FANCNFSM4LVKYXQQ>
.
|
Collaborator
|
No hurries. These PRs can wait.
… On Mar 30, 2020, at 2:52 PM, ligiabernardet ***@***.***> wrote:
Dom, on a second thought... Jun detected an error in the UFS Weather Model
User's Guide. I'd like to do a PR for the public-v1 branch. I can do that
this afternoon.
On Mon, Mar 30, 2020 at 2:50 PM mzhangw ***@***.***> wrote:
> #420 is ready.
>
> > On Mar 30, 2020, at 2:49 PM, Dom Heinzeller ***@***.***>
> wrote:
> >
> >
> > Is this PR and NCAR/ccpp-framework#274 <
> NCAR/ccpp-framework#274> ready? If so, I'll go
> ahead and create the corresponding fv3atm and ufs-weathere-model PRs, and
> run the tests.
> >
> > —
> > You are receiving this because you authored the thread.
> > Reply to this email directly, view it on GitHub <
> #420 (comment)>, or
> unsubscribe <
> https://github.com/notifications/unsubscribe-auth/AG7TW2QWQ5ZKV45IMINVSB3RKEAT5ANCNFSM4LVKYXQQ
> >.
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#420 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AE7WQAW7RID4EZWMZJ763S3RKEAZBANCNFSM4LVKYXQQ>
> .
>
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#420 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5C2RPQAATWIZTYDZVDWKDRKEBBHANCNFSM4LVKYXQQ>.
|
Collaborator
|
The ufs-weather-model is now ready |
This was referenced Mar 30, 2020
climbfuji
approved these changes
Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR include typo fixes, and missing suites in all suite table (Thanks @ligiabernardet )and some Doxygen warning fixes. It has passed full RTs for release/public-v1 branch.
The website has been refreshed to reflect the updates https://dtcenter.org/GMTB/v4.0/sci_doc/
rt_full.log