Skip to content

Update CCPP variable pdf files for SCM v4.0 and UFS v1.0 release.#274

Merged
climbfuji merged 4 commits into
NCAR:release/public-v4from
JulieSchramm:release/public-v4
Mar 31, 2020
Merged

Update CCPP variable pdf files for SCM v4.0 and UFS v1.0 release.#274
climbfuji merged 4 commits into
NCAR:release/public-v4from
JulieSchramm:release/public-v4

Conversation

@JulieSchramm
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is totally fine with me, but need corresponding PRs to update the submodule pointers in fv3atm and ufs-weather-model.

@ligiabernardet
Copy link
Copy Markdown
Collaborator

Thank you for updating these PDFs. Can you also remove the unnecessary files in these directory and leave just the PDFs?

@JulieSchramm
Copy link
Copy Markdown
Author

JulieSchramm commented Mar 26, 2020 via email

@climbfuji
Copy link
Copy Markdown
Collaborator

If I was really picky I would say we should move the PDFs one level up to the doc directory, but this requires changing the CCPP prebuild config in fv3atm (not a big deal, though) and various pieces of documentation that refer to those PDFS. Maybe not for the UFS v1.x.y release(s), but when we make the corresponding change for the master branch we should consider this.

Also, can you confirm that without the makefile etc in the DevelopersGuide directory, one can create the PDF by running pdflatex? Are the instructions in the CCPP technical documentation consistent with this?

@JulieSchramm
Copy link
Copy Markdown
Author

JulieSchramm commented Mar 26, 2020 via email

Comment thread doc/DevelopersGuide/README.md Outdated
@climbfuji climbfuji merged commit 08763e9 into NCAR:release/public-v4 Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants