Add an option in dynamics to calculate omega in non-hydrostatic runs similar to hydrostatic method

[XiaqiongZhou-NOAA]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
• Commit 'test_changes.list' from previous step

---

Description:

This is to bring an update in dycore. An option is added in dynamics to calculate the omega in non-hydrostatics runs similar to hydrostatic method.

Commit Message:

    * atmos_cubed_sphere - 
                         A new parameter, pass_full_omega_to_physics_in_non_hydrostatic_mode, has been added in 
                         dycore. When set to true, the omega calculation will match that of hydrostatic runs, using the 
                         formula omega = dp/dt. The default value is false, where the calculation remains
                         omega = w * dp/dz as before.

Priority:

• Closes control_ras fails to compare on Acorn #1970

Sub component Pull Requests:

• FV3: Add an option in dynamics to calculate omega in non-hydrostatic runs similar to hydrostatic method NOAA-EMC/ufsatm#849
  • atmos_cubed_sphere : Cherry pick to add an option to calculate omega in non-hydrostatic runs similar to hydrostatic method NOAA-GFDL/GFDL_atmos_cubed_sphere#344

UFSWM Blocking Dependencies:

• None

---

Changes

Regression Test Changes (Please commit test_changes.list):

• No Baseline Changes.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[zach1221]

@XiaqiongZhou-NOAA would you be able to sync up your PR branches and provide Hera regression testing log for this PR?

[jkbk2004]

@zach1221 @FernandoAndrade-NOAA @BrianCurtis-NOAA This PR is ready.

[FernandoAndrade-NOAA]

Please be aware that there may be issues with the Jet RTs, there has been a reduction in performance due to hardware failures. The Jet support team is working on getting those resolved. I have a run going right now, but it is extremely slow. @jkbk2004 FYI

[BrianCurtis-NOAA]

Hercules logs show two failed tests due to timeout

[zach1221]

Hercules logs show two failed tests due to timeout

Yes, we think they are failing due to spack issue with mvapich2. It shows as timeout though in the rt log.

[jkbk2004]

Can we move on for merging? It's better to catch up subcomponent PR to be merged. I mean due to July 4 schedule.