Add omega calculation and change LSM diag option to RTs

[dpsarmie]

Commit Queue Requirements:

• Fill out all sections of this template.
• All sub component pull requests have been reviewed by their code managers.
• Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
• Commit 'test_changes.list' from previous step

---

Description:

This PR adds the new omega calculation for RTs that are run in non-hydrostatic mode. Changes have been made to diag_tables and only the global_control.nml.IN. The original implementation of the omega calculation in FV3 can be found here: #2327 and the related global workflow PR that implements this is here: NOAA-EMC/global-workflow#2751 .

IOPT_DIAG has been set to 2 for the remaining coupled test cases that had it set to 1. This should be the new default moving forward with the merge of #2354. Related GW issue is NOAA-EMC/global-workflow#2786.

Commit Message:

* UFSWM - Adds pass_full_omega_to_physics_in_non_hydrostatic_model parameter in the global_control.nml.IN namelist and
          sets it to true for non-hydrostatic runs. An additional field (omga) has been added to the diag_tables.

Priority:

• Normal

Git Tracking

UFSWM:

• Closes Add updated omega calculation pass to ufs-wm  #2372

Sub component Pull Requests:

• None

UFSWM Blocking Dependencies:

• None

---

Changes

Regression Test Changes (Please commit test_changes.list):

• PR Updates/Changes Baselines.

Input data Changes:

• None.

Library Changes/Upgrades:

• No Updates

---

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Derecho
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
• opnReqTest (complete task if unnecessary)

[XiaqiongZhou-NOAA]

Thank you very much for taking care of this
In terms of the diag_table used for regional and nesting, you do not need add omga since it will keep original way - calculate omega in post. No baseline should be changed for all regional and HAFS's regression tests.

[dpsarmie]

Thank you very much for taking care of this In terms of the diag_table used for regional and nesting, you do not need add omga since it will keep original way - calculate omega in post. No baseline should be changed for all regional and HAFS's regression tests.

Ok, thank you for taking a look at this. I will add those changes later today.

[dpsarmie]

I went ahead and redid the PR. The only changes now are to the global RTs and the regional RTs will remain as is.

[dpsarmie]

More changes were rolled into this PR. A couple of the RTs were missing the LSM option that should be a part of #2354. Those have been added and tested.

@HelinWei-NOAA thanks for pointing out the issue and let me know if anything else needs to be rolled in here.

I'll edit the overall PR text to reflect this soon.

[FernandoAndrade-NOAA]

Please go ahead and resync your branch, we'd like to get started with testing this PR today, thank you.

[FernandoAndrade-NOAA]

Please also commit the updated test_changes.list to verify which baselines need updates.

[dpsarmie]

Please also commit the updated test_changes.list to verify which baselines need updates.

I had to regenerate the list, I'll ping you here once it's committed.

[dpsarmie]

@FernandoAndrade-NOAA Ok test_changes.list was added. Let me know if you need anything else.

[FernandoAndrade-NOAA]

@BrianCurtis-NOAA getting started with baseline creation for this PR.

[FernandoAndrade-NOAA]

If manually editing test_changes.list in the future, please be sure to verify the editor is using LF instead of CRLF, otherwise it'll insert hidden characters that will cause issues

[BrianCurtis-NOAA]

Before testing can start it will need a new bl-date

[FernandoAndrade-NOAA]

Adding a note that the following tests failed comparison on Gaea after successful baseline recreation:
control_wam_debug intel
gnv1_nested intel

[BrianCurtis-NOAA]

Adding a note that the following tests failed comparison on Gaea after successful baseline recreation: control_wam_debug intel gnv1_nested intel

neither of those show up in the test_changes.list and the wam_debug one failed on WCOSS2. regenerate those baselines and try those two again. @dpsarmie can you check your old run logs to see if those tests passed?

[dpsarmie]

Adding a note that the following tests failed comparison on Gaea after successful baseline recreation: control_wam_debug intel gnv1_nested intel

neither of those show up in the test_changes.list and the wam_debug one failed on WCOSS2. regenerate those baselines and try those two again. @dpsarmie can you check your old run logs to see if those tests passed?

Just checked. The run that generated the test_changes.list was on Hercules and those tests are turned off for the Hercules platform. I'll run the tests on Hera and report back soon.

[BrianCurtis-NOAA]

Adding a note that the following tests failed comparison on Gaea after successful baseline recreation: control_wam_debug intel gnv1_nested intel

neither of those show up in the test_changes.list and the wam_debug one failed on WCOSS2. regenerate those baselines and try those two again. @dpsarmie can you check your old run logs to see if those tests passed?

Just checked. The run that generated the test_changes.list was on Hercules and those tests are turned off for the Hercules platform. I'll run the tests on Hera and report back soon.

@jkbk2004 This is a good data point to emphasize that we should work towards all tests being run on one platform or devise a testing method where all tests are run between two machines prior to joining the commit queue.

[dpsarmie]

Ok, full suite has run on Hera and yes, control_wam_debug intel and gnv1_nested intel are showing as needing new baselines.

[zach1221]

Ok, testing is complete, we can proceed with final review.