Add an option in dynamics to calculate omega in non-hydrostatic runs similar to hydrostatic method#849
Merged
Conversation
14 tasks
DusanJovic-NOAA
approved these changes
Jun 27, 2024
Collaborator
|
@XiaqiongZhou-NOAA cubed sphere PR is merged. Please update the submodule hash and revert the .gitmodule url. |
Contributor
Author
|
Done |
jkbk2004
approved these changes
Jul 3, 2024
Collaborator
|
@jkbk2004 we're approved and ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update is to update dynamics. A new parameter, pass_full_omega_to_physics_in_non_hydrostatic_mode, has been added in dynamics. When set to true, the omega calculation will match that of hydrostatic runs, using the formula omega = dp/dt. The default value is false, where the calculation remains omega = w * dp/dz as before.
Issue(s) addressed
None.
Testing
This update is tested on Hercules with both intel and gnu compiler and all UFS regression tests produced identical results with default setting.
Dependencies