Cherry pick to add an option to calculate omega in non-hydrostatic runs similar to hydrostatic method#344
Merged
Conversation
…ydrostatic mode when 'pass_full_omega_to_physics_in_non_hydrostatic_mode' is set to true
This was referenced Jun 14, 2024
lharris4
approved these changes
Jun 14, 2024
Contributor
lharris4
left a comment
lharris4
left a comment
There was a problem hiding this comment.
I think this looks good. Thank you for your careful implementation.
| if (.not. Atm(n)%flagstruct%hydrostatic .and. .not. Atm(n)%flagstruct%pass_full_omega_to_physics_in_non_hydrostatic_mode) then | ||
| Atm(n)%omga(isc:iec,jsc:jec,1:npz) = Atm(n)%delp(isc:iec,jsc:jec,1:npz) / Atm(n)%delz(isc:iec,jsc:jec,1:npz) * Atm(n)%w(isc:iec,jsc:jec,1:npz) | ||
| if(Atm(n)%flagstruct%nf_omega>0) then | ||
| call del2_cubed(& |
Contributor
There was a problem hiding this comment.
Good use of existing API.
6 tasks
bensonr
approved these changes
Jun 28, 2024
|
@laurenchilutti testing is complete on WM PR#2327. Please feel free to merge this cubed-sphere PR. |
|
Copying @bensonr as well. Rusty, if you're able to merge, this PR is ready. |
laurenchilutti
added a commit
to laurenchilutti/GFDL_atmos_cubed_sphere
that referenced
this pull request
Jul 11, 2024
…lar to hydrostatic mode when 'pass_full_omega_to_physics_in_non_hydrostatic_mode' is set to true (NOAA-GFDL#344)" This reverts commit 577fd5e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This update cherry-picks from Release 042022 (#184). A new parameter, pass_full_omega_to_physics_in_non_hydrostatic_mode, has been added. When set to true, the omega calculation will match that of hydrostatic runs, using the formula omega = dp/dt. The default value is false, where the calculation remains omega = w * dp/dz as before.
How Has This Been Tested?
This update is tested on Hercules with both intel and gnu compiler and all UFS regression tests produced identical results with default setting.
Checklist:
Please check all whether they apply or not