merge#4
Merged
tsachiherman merged 17 commits intotsachiherman:tsachi/nettestfail2from Jun 21, 2019
Merged
Conversation
This fixes a deviation from the spec. Currently, the code
(accidentally) filters all votePresent and voteVerified events
from the next round, if myPlayer.Period is large. Instead,
whether we filter votes from the next round should not be a
function of current period. As specified in the spec, we allow
votes with vote.Round = player.Round + 1 and vote.Period == 0
and vote.Step = {propose,soft,cert,next}
* Add support for zone exporting. * Add space between functions.
* Updating the docker file to work * Updating dockerfile after review * Slight tweak to dockerfile apt-get line(s)
…40) * GOAL2-614 Updated algoh so that logs will be captured if algod terminates before block watcher is initialized. Fix code analysis warnings. * Consolidated error collection into captureErrorLogs(). Removed blank identifiers.
fix filter for next round period 0 votes
TestDBConcurrencyRW assumes `/dev/shm` device exists. It doesn't on Mac, so use tmp folder in that case.
Fix TestDBConcurrencyRW test to run on Macs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explain the goal of this change and what problem it is solving.
Test Plan
How did you test these changes? Please provide the exact scenarios you tested in as much detail as possible including commands, output and rationale.