Add metrics to heartbeat event.#7
Merged
Karmastic merged 1 commit intoalgorand:masterfrom Jun 20, 2019
Merged
Conversation
|
|
Karmastic
reviewed
Jun 18, 2019
|
|
||
| values[counter.name] = strconv.FormatFloat(sum, 'f', -1, 32) | ||
| } | ||
|
|
Karmastic
approved these changes
Jun 18, 2019
Contributor
Karmastic
left a comment
Karmastic
left a comment
There was a problem hiding this comment.
One minor nit - won't block it but fixing it at some point would be good.
winder
referenced
this pull request
in winder/go-algorand
Jun 21, 2019
winder
added a commit
that referenced
this pull request
Jun 21, 2019
Fix nit from #7 and run 'make sanity'
stechu
pushed a commit
to stechu/go-algorand
that referenced
this pull request
Sep 25, 2019
Add mulw (multiple wide) TEAL command
pzbitskiy
pushed a commit
to pzbitskiy/go-algorand
that referenced
this pull request
Mar 12, 2020
asset opcodes and enums
tsachiherman
pushed a commit
that referenced
this pull request
Mar 22, 2021
algorandskiy
referenced
this pull request
in algorandskiy/go-algorand
Jan 18, 2022
…rces Check resource deletion in balances interface
shiqizng
added a commit
to shiqizng/go-algorand
that referenced
this pull request
Apr 4, 2022
btcgenz
added a commit
to Swarm-Cool/swm-miner
that referenced
this pull request
Apr 7, 2025
garyrob
pushed a commit
to garyrob/go-hedgecoin
that referenced
this pull request
Feb 22, 2026
## Changes to spec.md ### Issue algorand#1: HTTP Status Code Handling Added proper status code checking in `doRequest()`: - Read full body with `io.ReadAll` before checking status - Handle non-2xx responses by trying to parse JSON error, otherwise return generic HTTP error ### Issue algorand#2 & algorand#3: Request Body Type Field - Explicitly stated that the `type` field is **removed** from request bodies - Added new section showing simplified request structs without `Type` field - Updated request/response documentation to note this change ### Issue algorand#4: Response Body Draining - Changed from `json.Decoder.Decode()` to `io.ReadAll()` + `json.Unmarshal()` - This ensures full body consumption for connection reuse even on error paths ### Issue algorand#5: Error Response Handling - Added structured error handling that distinguishes: - Non-2xx HTTP status: Try to parse JSON error from body, wrap as `DaemonError` or generic error - Connection errors: Return as-is ### Issue algorand#6: Python Daemon Error Format - Added `_send_json_response()` and `_send_json_error()` helper methods - All errors return JSON responses, not HTML - Error codes map to appropriate HTTP status codes ### Issue algorand#7: SetTimeouts() Implementation - Changed to use per-request context with timeout (`http.NewRequestWithContext`) - Dial timeout configured in Transport, query timeout used in context ### Issue algorand#8: Implementation Steps Order - Combined "Update Go Client" and "Update Go Test Server" into a single step - Updated plan.md to reflect this consolidation (now 3 implementation steps instead of 4) ### Additional Improvements - Added graceful shutdown documentation for Python daemon using `HTTPServer.shutdown()` - Added dial timeout configuration in Transport's DialContext
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The heartbeat telemetry event is sent every 10 minutes and allow a simple way to find nodes contributing telemetry data. Extend that event to include metrics.