Skip to content

Updating the docker file to work#53

Merged
Karmastic merged 3 commits intoalgorand:masterfrom
zacharyestep:master
Jun 20, 2019
Merged

Updating the docker file to work#53
Karmastic merged 3 commits intoalgorand:masterfrom
zacharyestep:master

Conversation

@zacharyestep
Copy link
Copy Markdown
Contributor

Summary

Had some trouble running the dev setup scripts in the provided docker file environment. They rely on sudo. Made changes.

Test Plan

Run build && test

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 19, 2019

CLA assistant check
All committers have signed the CLA.

Comment thread docker/Dockerfile Outdated
Comment thread docker/Dockerfile Outdated
Comment thread docker/Dockerfile Outdated
@zacharyestep
Copy link
Copy Markdown
Contributor Author

(closing and reopening for travis rebuild)

Copy link
Copy Markdown
Contributor

@Karmastic Karmastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to fix the dockerfile, please keep this PR focused on that. Addressing the assumptions around GITHUBREPO is a larger change that I would like to consider separately. Your changes only address a fraction of the total scope.

@zacharyestep
Copy link
Copy Markdown
Contributor Author

zacharyestep commented Jun 20, 2019

If you want to fix the dockerfile, please keep this PR focused on that. Addressing the assumptions around GITHUBREPO is a larger change that I would like to consider separately. Your changes only address a fraction of the total scope.

Reduced scope as desired. Do you request further changes?

Copy link
Copy Markdown
Contributor

@Karmastic Karmastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This works. I'm going to encourage prioritizing support for agile source location - you are correct it is an undue burden requiring a specific root folder location.

@Karmastic Karmastic merged commit 1b642f4 into algorand:master Jun 20, 2019
derbear pushed a commit to derbear/go-algorand that referenced this pull request Apr 28, 2020
Debugger: Allow debuging programs from transactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants