[GOAL2-796] re-enable firstvalid and lastvalid for goal clerk#55
Merged
zeldovich merged 13 commits intoalgorand:masterfrom Jun 20, 2019
Merged
[GOAL2-796] re-enable firstvalid and lastvalid for goal clerk#55zeldovich merged 13 commits intoalgorand:masterfrom
zeldovich merged 13 commits intoalgorand:masterfrom
Conversation
added 4 commits
June 19, 2019 12:12
…rks as it did before) and ConstructPaymentForRound (which is as ConstructPayment, but instead of being valid for curRound -> curRound+1000, it is valid for whatever passed rounds without validation)
…ers in goal clerk send
zeldovich
reviewed
Jun 19, 2019
zeldovich
reviewed
Jun 19, 2019
zeldovich
reviewed
Jun 19, 2019
derbear
previously requested changes
Jun 19, 2019
zeldovich
reviewed
Jun 19, 2019
added 3 commits
June 19, 2019 13:11
…has already been committed to anyways.
zeldovich
reviewed
Jun 19, 2019
zeldovich
reviewed
Jun 19, 2019
zeldovich
reviewed
Jun 19, 2019
zeldovich
reviewed
Jun 19, 2019
zeldovich
reviewed
Jun 19, 2019
zeldovich
reviewed
Jun 19, 2019
zeldovich
approved these changes
Jun 19, 2019
Karmastic
pushed a commit
that referenced
this pull request
Jun 20, 2019
derbear
pushed a commit
to derbear/go-algorand
that referenced
this pull request
Apr 29, 2020
Fix for pause on exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During the
kmd/algodintegration PR,goal clerk's--firstValidand--lastValidoptions were disabled. This PR proposes to re-enable these options.Of note, no additional validation is provided to these options: the user is allowed to enter whatever
--firstValidand--lastValidthey wish. Both must be provided as nonzero args for the default behavior (use the current round, and that round+1000, as the validity period).Test Plan
Used
goal clerk send -outto generate txfiles before and after the change, and thengoal clerk inspectto inspect them. Got expected output: before the change, txns were always valid from curRound to curRound+1000, after the change, the user can define these values.