Skip to content

Enable TRITON_EXT_ENABLED for Wheels Build#9935

Merged
CRobeck merged 5 commits into
mainfrom
CRobeck-patch-1
Apr 8, 2026
Merged

Enable TRITON_EXT_ENABLED for Wheels Build#9935
CRobeck merged 5 commits into
mainfrom
CRobeck-patch-1

Conversation

@CRobeck
Copy link
Copy Markdown
Contributor

@CRobeck CRobeck commented Apr 6, 2026

Enable Triton+LLVM symbol visibility by default to allow extensions to be natively shipped/package with Triton. This is part of the co-design of shipping extensions with PyTorch Triton release w/ @atalman.

Enable Triton+LLVM symbol visibility by default to allow extensions to be natively shipped/package with Triton .
@CRobeck CRobeck requested review from ThomasRaoux and atalman April 6, 2026 16:19
@CRobeck CRobeck requested a review from ptillet as a code owner April 6, 2026 16:19
@ThomasRaoux
Copy link
Copy Markdown
Collaborator

Do we have any safety check in case the plugin is built with a different Triton version?

@CRobeck CRobeck changed the title Enable TRITON_EXT_ENABLED by default for Triton+LLVM symbols Enable TRITON_EXT_ENABLED for Wheels Build Apr 6, 2026
@CRobeck
Copy link
Copy Markdown
Contributor Author

CRobeck commented Apr 6, 2026

Do we have any safety check in case the plugin is built with a different Triton version?

Updated in #9937

Copy link
Copy Markdown
Collaborator

@ThomasRaoux ThomasRaoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CRobeck CRobeck merged commit bf0e8a2 into main Apr 8, 2026
18 of 20 checks passed
@CRobeck CRobeck deleted the CRobeck-patch-1 branch April 8, 2026 13:30
CRobeck added a commit to CRobeck/triton that referenced this pull request Apr 8, 2026
Enable Triton+LLVM symbol visibility by default to allow extensions to
be natively shipped/package with Triton. This is part of the co-design
of shipping extensions with PyTorch Triton release w/ @atalman.

(cherry picked from commit bf0e8a2)
atalman pushed a commit that referenced this pull request Apr 10, 2026
…9959)

- **Enable TRITON_EXT_ENABLED for Wheels Build (#9935)**

<!---
The core Triton is a small number of people, and we receive many PRs
(thank
you!).  To help us review your code more quickly, **if you are a new
contributor (less than 3 PRs merged) we ask that you complete the
following
tasks and include the filled-out checklist in your PR description.**

Complete the following tasks before sending your PR, and replace `[ ]`
with
`[x]` to indicate you have done them.
-->

# New contributor declaration
- [ ] I am not making a trivial change, such as fixing a typo in a
comment.

- [ ] I have written a PR description following these
  [rules](https://cbea.ms/git-commit/#why-not-how).

- [ ] I have run `pre-commit run --from-ref origin/main --to-ref HEAD`.

- Select one of the following.
  - [ ] I have added tests.
    - `/test` for `lit` tests
    - `/unittest` for C++ tests
    - `/python/test` for end-to-end tests
  - [ ] This PR does not need a test because `FILL THIS IN`.

- Select one of the following.
  - [ ] I have not added any `lit` tests.
- [ ] The `lit` tests I have added follow these [best
practices](https://mlir.llvm.org/getting_started/TestingGuide/#filecheck-best-practices),
including the "tests should be minimal" section. (Usually running Python
code
    and using the instructions it generates is not minimal.)
plognjen pushed a commit to plognjen/triton that referenced this pull request Apr 14, 2026
Enable Triton+LLVM symbol visibility by default to allow extensions to
be natively shipped/package with Triton. This is part of the co-design
of shipping extensions with PyTorch Triton release w/ @atalman.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants