Skip to content

Add SQL Server-specific configuration section#12178

Merged
martint merged 1 commit intotrinodb:masterfrom
simpligility:sqlserver-isolation
Apr 29, 2022
Merged

Add SQL Server-specific configuration section#12178
martint merged 1 commit intotrinodb:masterfrom
simpligility:sqlserver-isolation

Conversation

@mosabua
Copy link
Copy Markdown
Member

@mosabua mosabua commented Apr 28, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Fix. Adds documentation for existing property .

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Documentation only

How would you describe this change to a non-technical end user or system administrator?

Adds documentation for existing property on SQL Server connector.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(✅ ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(✅ ) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@mosabua mosabua requested review from ebyhr and hashhar April 28, 2022 16:39
@github-actions github-actions bot added the docs label Apr 28, 2022
Copy link
Copy Markdown
Member Author

@mosabua mosabua Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code perspective I think it would be better to have sqlserver.snapshot-isolation.enabled with default true .. but we cant change that with just a doc change .. .. I spelled it out as a sentence because it can be confusing...

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebyhr ... I talked to @martint when we worked on the release notes and he agrees .. the property name and default value should be refactored ... can you file a ticket for that and slot that into the queue somehow?

@mosabua mosabua force-pushed the sqlserver-isolation branch from 9f4d2c5 to 8e72e6e Compare April 28, 2022 16:52
@cla-bot cla-bot bot added the cla-signed label Apr 28, 2022
@martint martint merged commit 6443576 into trinodb:master Apr 29, 2022
@github-actions github-actions bot added this to the 379 milestone Apr 29, 2022
@mosabua mosabua deleted the sqlserver-isolation branch April 29, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants