Add bulk insert support to SQL Server connector#12176
Merged
ebyhr merged 1 commit intotrinodb:masterfrom May 6, 2022
Merged
Conversation
jirassimok
force-pushed
the
sqlserver-bulk-writes
branch
from
1995ed6 to
0e1b7ca
Compare
Member
|
LGTM |
ebyhr
reviewed
Apr 28, 2022
plugin/trino-sqlserver/src/main/java/io/trino/plugin/sqlserver/SqlServerClient.java
Outdated
Show resolved
Hide resolved
jirassimok
force-pushed
the
sqlserver-bulk-writes
branch
from
0e1b7ca to
0216c46
Compare
mosabua
added
needs-docs
Member
|
Can you please add the doc segment as well.. or alternatively we can add a separate PR to be merged at the same time .. let me know what you prefer |
Member
Author
I'll add them. |
jirassimok
force-pushed
the
sqlserver-bulk-writes
branch
2 times, most recently
from
ba920b0 to
7b348c3
Compare
Member
|
In terms of the docs we might have to see how this combines with either this stuff https://docs.starburst.io/latest/connector/starburst-sqlserver.html#insert or the new docs merged with Also ... we should probably do the refactor of that property as well before we get this merge .. or even in here.. cc @hashhar @ebyhr @martint |
ebyhr
removed
the
needs-docs
ebyhr
reviewed
Apr 30, 2022
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Please bind session properties class in SqlServerClientModule.
bindSessionPropertiesProvider(binder, SqlServerSessionProperties.class);
jirassimok
force-pushed
the
sqlserver-bulk-writes
branch
2 times, most recently
from
5f8b708 to
0eb5b90
Compare
jirassimok
force-pushed
the
sqlserver-bulk-writes
branch
from
0eb5b90 to
011a854
Compare
ssheikin
approved these changes
May 5, 2022
Contributor
ssheikin
left a comment
ssheikin
left a comment
There was a problem hiding this comment.
lgtm.
I think you could squash commits.
Co-Authored-By: Sasha Sheikin <myminitrue@gmail.com>
ebyhr
force-pushed
the
sqlserver-bulk-writes
branch
from
011a854 to
65e6059
Compare
Member
|
Just squashed commits into one. |
ebyhr
approved these changes
May 6, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows SQL Server's bulk insert feature to be used when inserting data in Trino.
This feature was originally written for the Starburst Enterprise Platform, and is now being contributed to Trino.
This PR still needs the corresponding documentation changes.