Apply snapshot isolation to all SQL Server connection when it is enabled#11662
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Apr 23, 2022
Merged
Apply snapshot isolation to all SQL Server connection when it is enabled#11662ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
wendigo
approved these changes
Mar 25, 2022
Member
Does this PR fix them? |
findepi
reviewed
Mar 25, 2022
plugin/trino-sqlserver/src/main/java/io/trino/plugin/sqlserver/SqlServerClientModule.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Mar 25, 2022
plugin/trino-sqlserver/src/main/java/io/trino/plugin/sqlserver/SqlServerClientModule.java
Outdated
Show resolved
Hide resolved
hashhar
previously approved these changes
Mar 25, 2022
hashhar
reviewed
Mar 25, 2022
plugin/trino-sqlserver/src/main/java/io/trino/plugin/sqlserver/SqlServerClientModule.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/ebi/sqlserver-transaction
branch
from
b97f7eb to
660f048
Compare
Member
Author
It doesn't fix as far as I tried. I hope this PR mitigates it though. |
findepi
reviewed
Apr 22, 2022
plugin/trino-sqlserver/src/main/java/io/trino/plugin/sqlserver/SqlServerClient.java
Outdated
Show resolved
Hide resolved
ebyhr
commented
Apr 22, 2022
plugin/trino-sqlserver/src/main/java/io/trino/plugin/sqlserver/SqlServerConnectionFactory.java
Outdated
Show resolved
Hide resolved
findepi
approved these changes
Apr 22, 2022
plugin/trino-sqlserver/src/main/java/io/trino/plugin/sqlserver/SqlServerClientModule.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/ebi/sqlserver-transaction
branch
from
660f048 to
be76157
Compare
Connections generated in BaseJdbcClient didn't set transaction isolation even when it was enabled.
ebyhr
force-pushed
the
ebi/ebi/sqlserver-transaction
branch
from
be76157 to
1a723a3
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apply snapshot isolation to all SQL Server connection when it is enabled. I confirmed testSelectInformationSchemaColumns & testReadMetadataWithRelationsConcurrentModifications in BaseSqlServerConnectorTest are still flaky.
Documentation
(x) No documentation is needed.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: