Skip to content

Add SQL Server-specific configuration section #12178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martint merged 1 commit into from
Apr 29, 2022
Merged

Add SQL Server-specific configuration section #12178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions docs/src/main/sphinx/connector/sqlserver.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,23 @@ catalog named ``sales`` using the configured connector.

.. include:: jdbc-common-configurations.fragment

Specific configuration properties
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The SQL Server connector supports additional catalog properties to configure the
behavior of the connector and the issues queries to the database.

.. list-table::
:widths: 45, 55
:header-rows: 1

* - Property name
- Description
* - ``sqlserver.snapshot-isolation.disabled``
Copy link
Copy Markdown
Member Author

@mosabua mosabua Apr 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code perspective I think it would be better to have sqlserver.snapshot-isolation.enabled with default true .. but we cant change that with just a doc change .. .. I spelled it out as a sentence because it can be confusing...

Copy link
Copy Markdown
Member Author

@mosabua mosabua Apr 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebyhr ... I talked to @martint when we worked on the release notes and he agrees .. the property name and default value should be refactored ... can you file a ticket for that and slot that into the queue somehow?

- Control the automatic use of snapshot isolation for transactions issued by
Trino in SQL Server. Defaults to ``false``, which means that snapshot
isolation is enabled.

.. include:: jdbc-procedures.fragment

.. include:: jdbc-case-insensitive-matching.fragment
Expand Down