chore(utxo-lib): uprgade tiny-secp256k1#12261
chore(utxo-lib): uprgade tiny-secp256k1#12261peter-sanderson wants to merge 1 commit intodevelopfrom
Conversation
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is filesystem access?Accesses the file system, and could potentially read sensitive data. If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead. What are floating dependencies?Package has a dependency with a floating version range. This can cause issues if the dependency publishes a new major version. Packages should specify properly semver ranges to avoid version conflicts. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
3a144af to
0abe083
Compare
0abe083 to
c045dcc
Compare
|
Keep going! 💪 |
szymonlesisz
left a comment
There was a problem hiding this comment.
as we introduce new external file (wasm) this change should be carefully tested in multiple enviroments (for example by signing testnet transaction)
on desktop:
suite-web, suite-desktop, connect-popup, connect-webextension, connect-explorer
on mobile:
suite-mobile app, suite-web in browser, connect-popup in browser
| : []), | ||
| ], | ||
| // For tiny-secp256k1 | ||
| experiments: { asyncWebAssembly: true }, |
There was a problem hiding this comment.
is it required by tiny-secp256k1 or optional? if required then this should be added to all the projects which are using utxo-lib (connect, connect-iframe, connect-popup, connect-explorer)
i know that we build some other wasm files (cardano?), will this have effect on them as well?
|
|
||
| get privateKey(): Buffer | undefined { | ||
| return this.__D; | ||
| return uin8ArrayToBuffer(this.__D) ?? undefined; |
There was a problem hiding this comment.
is this needed? this.__D is defined as Buffer and should be a Buffer.
this comment applies for all the usage of uin8ArrayToBuffer in this file
| ? Buffer | ||
| : T extends null | ||
| ? null | ||
| : undefined; |
There was a problem hiding this comment.
note te me - to be discussed
Description
Related Issue
Resolve #7612
Screenshots: