Skip to content

Bump foundation deps 2025.04#18087

Merged
Lemonexe merged 4 commits intodevelopfrom
bump-foundation-deps-2025.04
Apr 2, 2025
Merged

Bump foundation deps 2025.04#18087
Lemonexe merged 4 commits intodevelopfrom
bump-foundation-deps-2025.04

Conversation

@Lemonexe
Copy link
Copy Markdown
Contributor

@Lemonexe Lemonexe commented Apr 2, 2025

Description

Update most Foundation-related dependencies.

major version:
N/A

minor version:

  • electron
  • electron-updater
  • @eslint/js
  • eslint
  • eslint-plugin-mdx
  • typescript-eslint

patch version:

  • electron-builder

not updated:

  • tiny-secp256k1 TODO in #12261
  • electron-store blocked by #14482
  • TODO #18106 broadcast-channel: I investigated and found that the code around it is useless →remove!
  • TODO #18090 react-hook-form & @hookform/resolvers includes a change of TS inference that breaks TS in useSignVerifyForm
  • TODO #18091 @electron/notarize@3.0.1 now only as ESM, but electron-builder hooks are CJS only??

ℹ️ For reference, last bump foundation deps PR was #17526
👁️ I skimmed through all code changes except eslint-related packages and electron ; found nothing suspicious ✅

Related Issue

Resolve #18047

QA

👁️ Besides CI checks, I have tested locally:

  • suite dev desktop
    • app builds & runs
    • tor works
  • suite desktop build for Linux:
    • app builds & runs
    • tor works
    • app update works
  • suite desktop build for Windows (built from Linux):
    • app builds & runs
    • tor works
    • app update works

@coderabbitai ignore

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2025

🔍🌐 Suite Web test results: View in Currents

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2025

🔍🖥️ Suite Desktop test results: View in Currents

@Lemonexe Lemonexe force-pushed the bump-foundation-deps-2025.04 branch from dd16b32 to 21a9ab5 Compare April 2, 2025 12:34
@Lemonexe
Copy link
Copy Markdown
Contributor Author

Lemonexe commented Apr 2, 2025

Failing test is confirmed to be broken (slack)

@Lemonexe Lemonexe marked this pull request as ready for review April 2, 2025 13:05
@Lemonexe Lemonexe merged commit 6145d3b into develop Apr 2, 2025
76 of 77 checks passed
@Lemonexe Lemonexe deleted the bump-foundation-deps-2025.04 branch April 2, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump foundation deps (2025.04)

2 participants