Conversation
Lemonexe
force-pushed
the
bump_foundation_deps_2025.10
branch
from
58605b1 to
bc857c0
Compare
| stream-browserify | ||
| swr | ||
| tailwindcss | ||
| tar |
There was a problem hiding this comment.
this is only used in script connect-bump-versions.ts so I'm reassigning this to connect team
Lemonexe
force-pushed
the
bump_foundation_deps_2025.10
branch
from
bc857c0 to
f55891a
Compare
|
✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
| FormValues extends BuyFormValues | ExchangeFormValues | SellFormValues, | ||
| type BottomSheetControls = ReturnType<typeof useBottomSheetControls>; | ||
| type FormUnion = BuyFormValues | ExchangeFormValues | SellFormValues; | ||
| // explicit return type declaration, because typescript reaches its limits when trying to infer type |
There was a problem hiding this comment.
after bumping react-hook-form, TS blew on me at useSheetControls:
TS5088: The inferred type of 'useSheetControls' references a type with a cyclic structure which cannot be trivially serialized. A type annotation is necessary.
TS7056: The inferred type of this node exceeds the maximum length the compiler will serialize. An explicit type annotation is needed.
Consultation with GPT-5 told me I should explicitly define return type, as TS can no longer handle the complexity of the inferred type. After a bit of tinkering, this satisfies TS. But I cannot say I understand these types, the labyrinth of generic types in the react-hook-form library confuses the hell out of me 😆
Lemonexe
force-pushed
the
bump_foundation_deps_2025.10
branch
from
f55891a to
54182db
Compare
|
Will merge despite failing |
|
/rebase |
trezor-bot
Bot
force-pushed
the
bump_foundation_deps_2025.10
branch
from
54182db to
e42c624
Compare
OriginalEveres
left a comment
OriginalEveres
left a comment
There was a problem hiding this comment.
code LGTM and briefly tested, approving
2 participants
Description
Update most Foundation-related dependencies.
major version:
eslint-plugin-react-hooksminor version:
typescript-eslint@eslint/jseslintreact-routerglobalsreact-hook-formtarpatch version:
@hookform/resolversnot updated:
electronbecause of bug in latest version, see #22188uuidTODO in #22316 new major version is ESM only, but blocked by playwright, not by electron-mainelectron-store + chalkTODO in #14482@noble/hashesnew major version is ESM only, adding to this list. But even if it wasn't, not worth upgrading: direct code usage in trezor-suite is minimal, mostly it's a subdep of other deps, and those still pin1.8.0. In such a case I think it's best to use the same version as required by our deps.tiny-secp256k1TODO in #12261nxTODO in #18812electron-builderTODO in #18919ℹ️ For reference, last bump foundation deps PR was #21285
Related Issue
Resolve #22187
Dev QA
👁️ Besides CI checks and the QA instructions in issue, I have tested locally:
tar: tried locallyyarn tsx ./scripts/ci/connect-bump-versions.tsbut early returning beforegit push, works well🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite desktop test results: View in Currents
🔍🖥️ Suite native android test results: View in Currents